Ooooooh... good to know. Kovu did something like this a while ago, and it's basically wrapping around the features from GL Lighting into a minecraft entity, which is why they're limited to 10 or so lights, but then they look super cool, update dynamically, etc.
One of the limitations being: they go through walls
I didn't look super closely, and just assumed it was solving all of the problems with magic. Bummer.
Yeah, I think the purplish-hue on the water is coming from the orange/reddish light from the lava and the blue moonlight going on at nighttime. I remember when I was messing with one of the shader mods (forever ago), the shaders would shift everything towards warmer colors... so the colored lamps didn't even look that great. It was the lava and torches that looked amazing.
man this version is making my modpack FPS drop from 67 to 19... is there a way to download a older version of your mod? i use to have a good one..
Things get weird as far as Curse is concerned, as they really only want me to release "updates" to the mod... I have a few older versions, but I don't want to add them as stand-alones, because then it will look like I'm releasing an Update, when I'm actually releasing an older version.
I might be able to zip up some of the older versions, and host that on the side.
Edit: I just submitted the 5 versions I have on hand in a zip file. I'm not sure if those will go back far enough get you your framerate back, and I honestly don't expect it to change much at all. CLC was a small hit on FPS through most iterations... and there's nothing that we did through development that should have caused it to tank from 67 to 19. All versions of CLC would likely do something like that given your setup, but I'm very surprised the difference is that large. Were you generating world nearby? Maybe something was tanking performance on the lighting-engine side of things. There were always some bugs in that thing, and I wouldn't be surprised if CPU thrashing could happen near corners or cases where the lighting algo just freaks out.
I had a working version on 1.8 (updated some lighting code, wrote some of my own), while on vacation in Colorado. The new version didn't require as many ASM modifications, (just 3 if I remember correctly), but required a relatively newer graphics card, although it may have worked on older machines. I've not decided if I want to go back into mod development, as it takes much time and TBH I don't have a lot of time. What's the current state of modding? (PM me please to prevent derailing).
Yeah... From what I saw, 1.8 could make this a bit easier, because of the rendering changes. Can you host what you did on Github at all?
if anyone is still working on this mod or has decided to pick it up, it has graphical issues with blue power mod and flans mod. both have graphical rendering glitches.
Have you tried r/feedthebeast to see if anyone is interested in helping out? Maybe the Forge irc/forums?
The mod wasn't very big... so I don't feel comfortable just blasting it all over the internet in big bold words "I'M DONE, HAVE A GREAT DAY" everywhere... I'm not a big deal... and I don't want to be.
PSA: I don't think I'm going to work on this mod very much anymore.
I will continue maintaining the git-repo, and I'll make sure the build server stays up... If anyone submits a PR, or wants to develop/make changes to the mod in a significant way, the door is wide open. I'll review code to the best of my ability, and make sure things stay the same, but I simply don't have any motivation to spend hours of my life learning Java + ASM.
Since many of you may not know what that is... I'll try to give you guys a 2 second low-down:
Minecraft by itself doesn't have colored lights... or any ability to color lights in its unmodded state. So my job is to stop Minecraft from loading, grab the classes that handle light calculations, light data, world saves, etc, and modify them. This modification is usually hacky to some extent, and requires a deep understanding of how Minecraft's rendering pipeline works, as well as interactions between modified classes, and the Java Virtual Machine (JVM). There are some libraries that can help modders make changes like I was doing: (ASM) And I was able to use Forge to create a Core-Mod that would alter Minecraft as it was loaded into RAM.
If everything works, you get to see colors, and your worlds are STILL backwards compatible.
The issues that I kept on running into are twofold.
1.) I don't know ASM that well... and how I need to use it to satisfy the JVM... It's a LOT of guess + check. Doing simple things like adding variables could take me hours if I didn't know what was going wrong. Here are the 17 lines of code that set the default sunlight color variable in the world class. It's not simple stuff... and writing that kind of code isn't fun for me either. I'm sure there are better ways of doing it... and I simply don't want to find out anymore.
2.) I don't know NEARLY enough about OpenGL. At first, I wasn't using much of OpenGL to add color to the world, but it became increasingly clear that I'd need delve into OpenGL and shaders to get everything to work. I don't have a clear understanding still... Murray and a couple others were able to start the implementation, and we got most of it working. So while I can see what's going on in the current setup, I don't know how to rewrite a "better shader" or fix the issues that currently exist in the pipeline. (This is what causes so many issues with Optifine and the ShaderCore)
So... what does that mean?
I'll make sure things compile. And I'll make sure to help anyone who wants to show up, and start turning wrenches and writing code. But... my interests have moved on. When Minecraft moves to C++ (the Windows 10 release thing), I might look at it again, but I don't need more Java right now... especially ASM + Java... It's not a very useful skill for what I do (embedded systems developer/engineer) and I'm sad I have to break it to you all. It hasn't been all bad, and I've had moments that were a TON of fun!
0
Ooooooh... good to know. Kovu did something like this a while ago, and it's basically wrapping around the features from GL Lighting into a minecraft entity, which is why they're limited to 10 or so lights, but then they look super cool, update dynamically, etc.
One of the limitations being: they go through walls
I didn't look super closely, and just assumed it was solving all of the problems with magic. Bummer.
1
Yeah, I think the purplish-hue on the water is coming from the orange/reddish light from the lava and the blue moonlight going on at nighttime. I remember when I was messing with one of the shader mods (forever ago), the shaders would shift everything towards warmer colors... so the colored lamps didn't even look that great. It was the lava and torches that looked amazing.
https://i.imgur.com/Tx3Napd.png
https://i.imgur.com/VM9bu1i.jpg
0
Someone made a new shader based implementation here: https://github.com/elytra/Albedo
It looks pretty neat.
1
This
0
Not likely.
2
?
0
Things get weird as far as Curse is concerned, as they really only want me to release "updates" to the mod... I have a few older versions, but I don't want to add them as stand-alones, because then it will look like I'm releasing an Update, when I'm actually releasing an older version.
I might be able to zip up some of the older versions, and host that on the side.
Edit: I just submitted the 5 versions I have on hand in a zip file. I'm not sure if those will go back far enough get you your framerate back, and I honestly don't expect it to change much at all. CLC was a small hit on FPS through most iterations... and there's nothing that we did through development that should have caused it to tank from 67 to 19. All versions of CLC would likely do something like that given your setup, but I'm very surprised the difference is that large. Were you generating world nearby? Maybe something was tanking performance on the lighting-engine side of things. There were always some bugs in that thing, and I wouldn't be surprised if CPU thrashing could happen near corners or cases where the lighting algo just freaks out.
1
I submitted one of the later releases to curse-forge. It should be live, but "experimental".
https://minecraft.curseforge.com/projects/colored-light-core
I am unaware of the current state of affairs, and expect issues with an older version of Forge being required.
1
I took my Jenkins server down... but that took the mod down with it ._.
I'll see what I can do to try and get something back up and running... there might be a place on curse that I can host the old Jars...
Do people still really want to run this thing?
0
You can find a couple of the devs on IRC, but they should already know. I wouldn't suggest looking for their email, or bothering them.
0
Yeah... From what I saw, 1.8 could make this a bit easier, because of the rendering changes. Can you host what you did on Github at all?
0
Many of these things have already been noted. Thank you for posting
https://docs.google.com/spreadsheets/d/1mfAradGBs1U2LOVHIW6_2FNKnc4pKB00qr9VAYtrKZc/pubhtml
2
The mod wasn't very big... so I don't feel comfortable just blasting it all over the internet in big bold words "I'M DONE, HAVE A GREAT DAY" everywhere... I'm not a big deal... and I don't want to be.
6
PSA: I don't think I'm going to work on this mod very much anymore.
I will continue maintaining the git-repo, and I'll make sure the build server stays up... If anyone submits a PR, or wants to develop/make changes to the mod in a significant way, the door is wide open. I'll review code to the best of my ability, and make sure things stay the same, but I simply don't have any motivation to spend hours of my life learning Java + ASM.
Since many of you may not know what that is... I'll try to give you guys a 2 second low-down:
Minecraft by itself doesn't have colored lights... or any ability to color lights in its unmodded state. So my job is to stop Minecraft from loading, grab the classes that handle light calculations, light data, world saves, etc, and modify them. This modification is usually hacky to some extent, and requires a deep understanding of how Minecraft's rendering pipeline works, as well as interactions between modified classes, and the Java Virtual Machine (JVM). There are some libraries that can help modders make changes like I was doing: (ASM) And I was able to use Forge to create a Core-Mod that would alter Minecraft as it was loaded into RAM.
If everything works, you get to see colors, and your worlds are STILL backwards compatible.
The issues that I kept on running into are twofold.
1.) I don't know ASM that well... and how I need to use it to satisfy the JVM... It's a LOT of guess + check. Doing simple things like adding variables could take me hours if I didn't know what was going wrong. Here are the 17 lines of code that set the default sunlight color variable in the world class. It's not simple stuff... and writing that kind of code isn't fun for me either. I'm sure there are better ways of doing it... and I simply don't want to find out anymore.
2.) I don't know NEARLY enough about OpenGL. At first, I wasn't using much of OpenGL to add color to the world, but it became increasingly clear that I'd need delve into OpenGL and shaders to get everything to work. I don't have a clear understanding still... Murray and a couple others were able to start the implementation, and we got most of it working. So while I can see what's going on in the current setup, I don't know how to rewrite a "better shader" or fix the issues that currently exist in the pipeline. (This is what causes so many issues with Optifine and the ShaderCore)
So... what does that mean?
I'll make sure things compile. And I'll make sure to help anyone who wants to show up, and start turning wrenches and writing code. But... my interests have moved on. When Minecraft moves to C++ (the Windows 10 release thing), I might look at it again, but I don't need more Java right now... especially ASM + Java... It's not a very useful skill for what I do (embedded systems developer/engineer) and I'm sad I have to break it to you all. It hasn't been all bad, and I've had moments that were a TON of fun!
I hope we can still be friends,
-CptSpaceToaster-
(I'll stick a copy of this in the OP)
0
How does renaming CLC to something else get it to load earlier? There shouldn't be any other mods in the folder when you try this.