Minecraft Forums

I have found an oddity in the custom_water_flowing animation and I wonder if anyone here or Xau himself can help me to understand what is going on.

I'm using v.1.1.7 of this mod, v1.2.1_01 of the downloadable Minecraft client, and I'm using a 128 pixel texture set. My custom_water_flowing.png file is 128px x 2048px.

Flowing water appears to offset the texture horizontally by 64 pixels. This was noticable to me since my water texture does not tile perfectly and it created a seam in the center of a 1 x 7 stream. I offset my texture 64 pixels horizontally and it perfectly matched in-game. ( dimensional values are probably unimportant here, I suspect it is offsetting by 1/2 the texture width regardless of pixel count )

Solution found, I accepted this anomally and moved on. But then I noticed that I had another anomaly.

128px x 2048px should provide a perfect seamless transition from the top of my custom_water_flowing file to the bottom as the source file tiles and I move my sample source precisely 8 pixels per tile from the bottom of the source file arriving at the top of the source file on the final sample.

But I noticed that the origin of the tiling of the flowing water was also offset. It begins 64 pixels into the first tile as well. This may have been done purposefully in order to improve tiling, but it greatly complicated making perfectly tiling flowing water.

I'm not sure how to correct for this other than offseting horizontally and vertically every single tile in my custom_water_flowing.png. I can do that, and it's trivial, but surely this is not meant to be the way that the tiling works. Or is it Xau?

If I've failed to explain this well enough you can cut a stream up to a still body of water and examine the block of flowing water that extends into the lake. This flowing block, and all the others, will exhibit a seam in it's center and no seam at the block edge leading into the stream. I can upload a clip if necessary, but it should be pretty obvious.

Quote from copperdomebodha »

Flowing water appears to offset the texture horizontally by 64 pixels.

See way back here and my response on why it happens. Basically it uses the middle of 4 tiles with the same texture so that the corners are filled in when it's rotated.

I'd just like to clarify why the patcher "doesn't work" on some OS X systems.

First off, the problem is due to attempting to run the patcher with a Java version lower than the one that xau compiled the patcher with. I'm assuming xau compiled using Java 1.6, the newest version.

Anyone running Snow Leopard (10.6) should be able to run the patcher without any problems, since Snow Leopard comes with Java 1.6 in both 32-bit and 64-bit. So if you double-click the .jar it opens up fine.

Some Leopard (10.5) systems get an error when double-clicking the .jar. This is because Apple has only released a 64-bit version of Java 1.6 for Leopard, alongside 64-bit and 32-bit Java 1.5. This means two things:

1. A very small number of Leopard users are using a computer that isn't 64-bit capable. Thus you don't have Java 1.6 installed and the workaround shouldn't work either. Unfortunately there's not much you can do.

2. All other Leopard users have a 64-bit capable machine and thus do have Java 1.6 and should be able to run the patcher just by double-clicking it.

Now here is what I recommend for all Leopard users:

1. Open Software Update and make sure all Java Updates are installed.

And the important part:
2. Open up the Java Preferences application in /Applications/Utilities. There will most likely be an entry called "Java SE 6". This means your computer is 64-bit capable and has Java 1.6. Make sure the entry is checked and at the top of the list. If it isn't, this is why the workaround was needed; because Java 1.6 was either not enabled or wasn't the default version. So check it and drag it to the top. This makes Java 1.6 the default version on your system.



Now try double-clicking the patcher. It should open up fine and work as expected. No more workaround!

Let me know if you have any questions/problems regarding this.

@xau, I'd suggest changing the OP since the patcher should actually work for almost all OS X systems, without the need for the workaround provided these steps are followed. :smile.gif:

Quote from xau »

Quote from copperdomebodha »

Flowing water appears to offset the texture horizontally by 64 pixels.

See way back here and my response on why it happens. Basically it uses the middle of 4 tiles with the same texture so that the corners are filled in when it's rotated.

Xau,

Thanks for your time! That IS very interesting, and I did miss it previously, I'll have to incorporate that in my pack. But I don't think that we're speaking about the same issue.

Here's a custom_water_flowing.png...



And here's that custom_water_flowing.png used in-game showing the issue I'm addressing.


Thanks agin for the mod and your support!

Quote from copperdomebodha »

But I don't think that we're speaking about the same issue.

Your water animation is drawn on 4 tiles (the yellow, green, orange, and red tiles in dustyshouri's image). Then the middle of those 4 tiles is drawn on your water blocks. So the + created by the 4 borders appears in the middle of the block.

Quote from moontrain »

@xau, I'd suggest changing the OP since the patcher should actually work for almost all OS X systems, without the need for the workaround provided these steps are followed. :smile.gif:

It's a temporary workaround, the next release will be back to supporting Java 1.5.

Quote from CobraA1 »

Any word on the compasses/watches getting fixed?

I've been working on a 1.2.x version of the patcher with more generic mod support, but if I'm not finishing up by the end of the week I'll fix them (and portals) on 1.1.x and release that.

Quote from xau »

Quote from copperdomebodha »

But I don't think that we're speaking about the same issue.

Your water animation is drawn on 4 tiles (the yellow, green, orange, and red tiles in dustyshouri's image). Then the middle of those 4 tiles is drawn on your water blocks. So the + created by the 4 borders appears in the middle of the block.

Ah! Thanks for clarifying that for me!

Quote from CobraA1 »

Any word on the compasses/watches getting fixed?

Also, what is the water issue, mine looks fine at first glance. (Using Brown & Bloom)

probably about my 5th time posting here, but now that I finally figured out the workaround, minecraft crashes. I'm trying to use the Animal Crafting texture pack. heres what my clipboard says


Found FlowLava: eg.class
Found AnimManager: ey.class
Found Tessellator: ho.class
Found FlowWater: ht.class
Found StillWater: ht.class
Found Tool3D: jh.class
Found Fire: jz.class
Found Block: ly.class
Found AnimTexture: z.class
Found Minecraft: net/minecraft/client/Minecraft.class
No classes match for StillLava
No classes match for Compass
Found AnimTexture: ab.class
Found Compass: ac.class
Found StillLava: ay.class
Found FlowLava: et.class
Found AnimManager: fm.class
Found Tessellator: ij.class
Found FlowWater: iq.class
Found Tool3D: kj.class
Found Fire: lb.class
Found Block: ne.class
Found StillWater: nr.class
Found Minecraft: net/minecraft/client/Minecraft.class
Patching class: AnimTexture (ab.class)
Fix new array[1024] -> 16384 - <init>@5
Patching class: Compass (ac.class)
Change constant value 8.5 -> 32.5
Change constant value 7.5 -> 31.5
Fix new array[256] -> 4096 - <init>@12
Fix * 16 -> 64 - <init>@48
Fix * 16 -> 64 - <init>@59
.getRGB(...16,16,...16) to .getRGB(...64,64,...64) - <init>@68
Fix while(i<256) -> while(i<4096) - [email protected]
Fix * 16 -> 64 - [email protected]
Fix * 16 -> 64 - [email protected]
Update const reference 37 -> 158 - [email protected]
Update const reference 37 -> 158 - [email protected]
Update const reference 35 -> 160 - [email protected]
Update const reference 35 -> 160 - [email protected]
Replacing ay.class
Replacing et.class
Patching class: AnimManager (fm.class)
Change constant value 1048576 -> 4194304
Update const reference 2 -> 318 - <init>@35
Fix %16*16+_3*16 -> %16*64+_3*64 - [email protected]
Fix /16*16+_4*16 -> /16*64+_4*64 - [email protected]
glTexSubImage2D(...,16,16) -> glTexSubImage2D(...,64,64) - [email protected]
glTexSubImage2D(...,16,16) -> glTexSubImage2D(...,64,64) - [email protected]
Replacing iq.class
Patching class: Tool3D (kj.class)
Change constant value 16.0 -> 64.0
Change constant value 0.001953125 -> 1.2207031E-4
tool pixel top - [email protected]
Update const reference 32 -> 317 - [email protected]
Update const reference 32 -> 317 - [email protected]
Update const reference 32 -> 317 - [email protected]
Update const reference 32 -> 317 - [email protected]
Fix while(i<16) -> while(i<64) - [email protected]
Fix while(i<16) -> while(i<64) - [email protected]
Fix while(i<16) -> while(i<64) - [email protected]
Fix while(i<16) -> while(i<64) - [email protected]
Update const reference 11 -> 318 - [email protected]
Update const reference 11 -> 318 - [email protected]
Update const reference 11 -> 318 - [email protected]
Update const reference 11 -> 318 - [email protected]
Patching class: Fire (lb.class)
Change constant value 1.06 -> 1.02
Fix new array[320] -> 4352 - <init>@16
Fix new array[320] -> 4352 - <init>@25
Fix * 16 -> 64 - <init>@8
(unpatch) <init> *64 to *16 - <init>@7
Fix while(i<256) -> while(i<4096) - [email protected]
Fix while(i<20) -> while(i<68) - [email protected]
Fix while(i<20) -> while(i<68) - [email protected]
Fix while(i<16) -> while(i<64) - [email protected]
Fix while(i<16) -> while(i<64) - [email protected]
Fix * 16 -> 64 - [email protected]
Fix * 16 -> 64 - [email protected]
Fix * 16 -> 64 - [email protected]
Fix * 16 -> 64 - [email protected]
Fix mod 20 -> 68 - [email protected]
Fix ILOAD_2; if_icmplt 19 -> if_icmplt 67 - [email protected]
Update const reference 2 -> 58 - [email protected]
Replacing nr.class
Reading terrain.png...
Resizing terrain.png from 256x256 to 1024x1024
Reading gui/items.png...
Patching class: Minecraft (net/minecraft/client/Minecraft.class)
pass Minecraft to nr.<init> - <init>@124
pass Minecraft to iq.<init> - [email protected]
pass Minecraft to ay.<init> - <init>@136
pass Minecraft to et.<init> - [email protected]
Replacing WaterAnimation.class


#### Success! ...probably ####
[java, -cp, /Users/charliesachs/Library/Application Support/minecraft/bin/minecraft.jar:/Users/charliesachs/Library/Application Support/minecraft/bin/lwjgl.jar:/Users/charliesachs/Library/Application Support/minecraft/bin/lwjgl_util.jar:/Users/charliesachs/Library/Application Support/minecraft/bin/jinput.jar, -Djava.library.path=/Users/charliesachs/Library/Application Support/minecraft/bin/natives, -Xmx1024M, -Xms512M, net.minecraft.client.Minecraft]
28
java.io.EOFException
at javax.imageio.stream.ImageInputStreamImpl.readFully(ImageInputStreamImpl.java:330)
at java.io.DataInputStream.readUTF(DataInputStream.java:565)
at javax.imageio.stream.ImageInputStreamImpl.readUTF(ImageInputStreamImpl.java:309)
at com.sun.imageio.plugins.png.PNGImageReader.parse_iTXt_chunk(PNGImageReader.java:443)
at com.sun.imageio.plugins.png.PNGImageReader.readMetadata(PNGImageReader.java:652)
at com.sun.imageio.plugins.png.PNGImageReader.readImage(PNGImageReader.java:1314)
at com.sun.imageio.plugins.png.PNGImageReader.read(PNGImageReader.java:1601)
at javax.imageio.ImageIO.read(ImageIO.java:1400)
at javax.imageio.ImageIO.read(ImageIO.java:1322)
at fm.a(SourceFile:58)
at net.minecraft.client.Minecraft.q(SourceFile:303)
at net.minecraft.client.Minecraft.a(SourceFile:216)
at net.minecraft.client.Minecraft.run(SourceFile:560)
at java.lang.Thread.run(Thread.java:655)
java.lang.RuntimeException: !!
at fm.a(SourceFile:64)
at net.minecraft.client.Minecraft.q(SourceFile:303)
at net.minecraft.client.Minecraft.a(SourceFile:216)
at net.minecraft.client.Minecraft.run(SourceFile:560)
at java.lang.Thread.run(Thread.java:655)
[java, -cp, /Users/charliesachs/Library/Application Support/minecraft/bin/minecraft.jar:/Users/charliesachs/Library/Application Support/minecraft/bin/lwjgl.jar:/Users/charliesachs/Library/Application Support/minecraft/bin/lwjgl_util.jar:/Users/charliesachs/Library/Application Support/minecraft/bin/jinput.jar, -Djava.library.path=/Users/charliesachs/Library/Application Support/minecraft/bin/natives, -Xmx1024M, -Xms512M, net.minecraft.client.Minecraft]
28
java.io.EOFException
at javax.imageio.stream.ImageInputStreamImpl.readFully(ImageInputStreamImpl.java:330)
at java.io.DataInputStream.readUTF(DataInputStream.java:565)
at javax.imageio.stream.ImageInputStreamImpl.readUTF(ImageInputStreamImpl.java:309)
at com.sun.imageio.plugins.png.PNGImageReader.parse_iTXt_chunk(PNGImageReader.java:443)
at com.sun.imageio.plugins.png.PNGImageReader.readMetadata(PNGImageReader.java:652)
at com.sun.imageio.plugins.png.PNGImageReader.readImage(PNGImageReader.java:1314)
at com.sun.imageio.plugins.png.PNGImageReader.read(PNGImageReader.java:1601)
at javax.imageio.ImageIO.read(ImageIO.java:1400)
at javax.imageio.ImageIO.read(ImageIO.java:1322)
at fm.a(SourceFile:58)
at net.minecraft.client.Minecraft.q(SourceFile:303)
at net.minecraft.client.Minecraft.a(SourceFile:216)
at net.minecraft.client.Minecraft.run(SourceFile:560)
at java.lang.Thread.run(Thread.java:655)
java.lang.RuntimeException: !!
at fm.a(SourceFile:64)
at net.minecraft.client.Minecraft.q(SourceFile:303)
at net.minecraft.client.Minecraft.a(SourceFile:216)
at net.minecraft.client.Minecraft.run(SourceFile:560)
at java.lang.Thread.run(Thread.java:655)

And heres what my Minecraft crash report says



Minecraft has crashed!
----------------------

Minecraft has stopped running because it encountered a problem.

If you wish to report this, please copy this entire text and email it to [email protected].
Please include a description of what you did when the error occured.



--- BEGIN ERROR REPORT a1dce528 --------
Generated 11/8/10 2:59 PM

Minecraft: Minecraft Alpha v1.2.1_01
OS: Mac OS X (i386) version 10.5.8
Java: 1.5.0_26, Apple Inc.
VM: Java HotSpot(TM) Client VM (mixed mode), Apple Inc.
LWJGL: 2.4.2
OpenGL: Intel GMA 950 OpenGL Engine version 1.2 APPLE-1.5.48, Intel Inc.

java.lang.RuntimeException: !!
at fm.a(SourceFile:64)
at net.minecraft.client.Minecraft.q(SourceFile:303)
at net.minecraft.client.Minecraft.a(SourceFile:216)
at net.minecraft.client.Minecraft.run(SourceFile:560)
at java.lang.Thread.run(Thread.java:655)
--- END ERROR REPORT 127a538f ----------

Thanks for any help you can give me.

Hey Xau, thank you for all your hard work on this patcher.

A quick feature request, for what it's worth: It'd be nice if custom high-res fonts were possible. As a completionist, I'd like to update the fonts in my graphics pack, but the game has some wacky letter spacing when I use a default.png with dimensions other than 128x128 (no shock there, except that I'm surprised it doesn't flip out far worse). I sure would like to make a smooth-looking HD version of the default font, but it seems off the table for now. I doubt this will end up ranking high on your to-do list, but I thought I'd throw it out there anyway.

How do i install the pack manually or repackage it as .jar or whatever? I'm realyl clueless here it wont let me fix my .zip folder

When I use the secret block thing, I make one, and than set the the on/off textures both to stone. Then i put a redstone torch of right clicks. I link it to my

[]
[]


However, when I click on it nothing happens. The wire doesn't light up either.
Thanks.

This reverts client version number back to 1.2.0_01 even when people have 1.2.1_01. Texture pack program should not even touch client version number of the jar so why is this happening?

Quote from drats666 »

This reverts client version number back to 1.2.0_01 even when people have 1.2.1_01. Texture pack program should not even touch client version number of the jar so why is this happening?

Doesn't do that for me...

It does it for me and my friends. it resets the version number from latest client of 1.2.1_01 to 1.2.0_01

Quote from drats666 »

It does it for me and my friends. it resets the version number from latest client of 1.2.1_01 to 1.2.0_01

Hit the Minecraft Folder button on the patcher. Close the patcher, keep the folder open. Delete minecraft.original.jar and the file called 'version'. Run Minecraft, let it download the latest, then run the patcher again. Next update delete minecraft.original.jar again before you patch.

Quote from ExcitedPeasant »

So Xau, why is it that only the 256x256 patching uses older OpenGL rules?

The patcher shows you exactly what it's changing. The only difference between 256x256 and 128x128 is that the numbers are (significantly) bigger.

Quote from ExcitedPeasant »

Also, any chance of the water not having that offset in the future? I find it interesting that even if you apply your own 64x64 offset, the 64 offset this applies still won't be seamless. I'll have to look into the images you referenced. This actually doesn't seem to happen anymore with custom_water_still/flowing, am I correct?

It's the way Minecraft draws flowing water, not something the patcher does. It will never be seamless on rotated tiles. It will happen with any flowing water and lava.

i'm getting this

java.lang.NoSuchFieldError: A
at lh.b(lh.java:100)
at cu.e(SourceFile:1023)
at net.minecraft.client.Minecraft.i(SourceFile:1133)
at net.minecraft.client.Minecraft.run(SourceFile:596)
at java.lang.Thread.run(Unknown Source)

Hi, I'm having a problem installing the Brown and Bloom texture pack v1.2. I can't get past 81% trying to update.

Here is the Java Log and Terminal output.

First the Java Log

Found AnimTexture: ab.class
Found Compass: ac.class
Found StillLava: ay.class
Found FlowLava: et.class
Found AnimManager: fm.class
Found Tessellator: ij.class
Found FlowWater: iq.class
Found Tool3D: kj.class
Found Fire: lb.class
Found Block: ne.class
Found StillWater: nr.class
Found Minecraft: net/minecraft/client/Minecraft.class
Patching class: AnimTexture (ab.class)
Fix new array[1024] -> 4096 - <init>@5
Patching class: Compass (ac.class)
Change constant value 8.5 -> 16.5
Change constant value 7.5 -> 15.5
Fix new array[256] -> 1024 - <init>@12
Fix * 16 -> 32 - <init>@48
Fix * 16 -> 32 - <init>@59
.getRGB(...16,16,...16) to .getRGB(...32,32,...32) - <init>@68
Fix while(i<256) -> while(i<1024) - [email protected]
Fix * 16 -> 32 - [email protected]
Fix * 16 -> 32 - [email protected]
Update const reference 37 -> 158 - [email protected]
Update const reference 37 -> 158 - [email protected]
Update const reference 35 -> 160 - [email protected]
Update const reference 35 -> 160 - [email protected]
Replacing ay.class
Replacing et.class
Patching class: AnimManager (fm.class)
Change constant value 1048576 -> 1048576
Update const reference 2 -> 318 - <init>@35
Fix %16*16+_3*16 -> %16*32+_3*32 - [email protected]
Fix /16*16+_4*16 -> /16*32+_4*32 - [email protected]
glTexSubImage2D(...,16,16) -> glTexSubImage2D(...,32,32) - [email protected]
glTexSubImage2D(...,16,16) -> glTexSubImage2D(...,32,32) - [email protected]
Replacing iq.class
Patching class: Tool3D (kj.class)
Change constant value 16.0 -> 32.0
Change constant value 0.001953125 -> 4.8828125E-4
tool pixel top - [email protected]
Update const reference 32 -> 317 - [email protected]
Update const reference 32 -> 317 - [email protected]
Update const reference 32 -> 317 - [email protected]
Update const reference 32 -> 317 - [email protected]
Fix while(i<16) -> while(i<32) - [email protected]
Fix while(i<16) -> while(i<32) - [email protected]
Fix while(i<16) -> while(i<32) - [email protected]
Fix while(i<16) -> while(i<32) - [email protected]
Update const reference 11 -> 318 - [email protected]
Update const reference 11 -> 318 - [email protected]
Update const reference 11 -> 318 - [email protected]
Update const reference 11 -> 318 - [email protected]
Patching class: Fire (lb.class)
Change constant value 1.06 -> 1.03
Fix new array[320] -> 1152 - <init>@16
Fix new array[320] -> 1152 - <init>@25
Fix * 16 -> 32 - <init>@8
(unpatch) <init> *32 to *16 - <init>@7
Fix while(i<256) -> while(i<1024) - [email protected]
Fix while(i<20) -> while(i<36) - [email protected]
Fix while(i<20) -> while(i<36) - [email protected]
Fix while(i<16) -> while(i<32) - [email protected]
Fix while(i<16) -> while(i<32) - [email protected]
Fix * 16 -> 32 - [email protected]
Fix * 16 -> 32 - [email protected]
Fix * 16 -> 32 - [email protected]
Fix * 16 -> 32 - [email protected]
Fix mod 20 -> 36 - [email protected]
Fix ILOAD_2; if_icmplt 19 -> if_icmplt 35 - [email protected]
Update const reference 2 -> 58 - [email protected]
Patching class: Block (ne.class)
Change constant value ClassRef{className='of'} -> ClassRef{className='BetterGrass'}
Change constant value MethodRef{className='of', name='<init>', type='(I)V'} -> MethodRef{className='BetterGrass', name='<init>', type='(I)V'}
Update const reference 97 -> 885 - <clinit>@212
Update const reference 383 -> 887 - <clinit>@217
Replacing nr.class
Reading terrain.png...

And now the Terminal error message.

Exception in thread "Thread-4" java.lang.OutOfMemoryError: Java heap space
at b.a.a.e.b.m.a(Unknown Source)
at b.a.a.e.b.c.a(Unknown Source)
at b.a.a.e.b.m(Unknown Source)
at b.a.a.e.b.a(Unknown Source)
at b.a.a.a.a(Unknown Source)
at af.a(Unknown Source)
at ag.b(Unknown Source)
at MCPatcher.a(Unknown Source)
at s.run(Unknown Source)
at m.run(Unknown Source)
at java.lang.Thread.run(Thread.java:680)


Is this an error with the Brown and Bloom package or the mcpatcher?

Thanks,
Hakone.