Minecraft Forums

... grr ...

I have a copy of mojang code (they marked their private ... why?) for testing where water can flow.

My code is doing

                b1.dropBlockAsItem(w, x0, y0, z0, m1, m1);
                w.setBlockToAir(x1, y1, z1);
                return 1;

Yet somehow a vine was triggered in the swamp ... how?!?

Gotta see if I can make this error happen on demand.

EDIT: GRR #2: Explicitly placing vines, and letting water flow through ... works as expected; block turns into air, vine is dropped, water flows through air. How did it die on me then?

Wow Keybounce awesome work trying to figure this out! Sorry I can't help you I can't mod to figure my way out of a bag! lol

Is there anyway to keep hte enableflow on even after a serer restart?

At the moment, no.

Soon, yes.

===

I cannot get the crash case to repeat. Same world, same area.

Alright, let me see what I can do. On the list:

(before release) Debug spam.

1. At least detect, and report without dying, when a block that should be broken already at water flow turns out not to be broken. Like that strange vine that somehow was not air. (DONE; cannot test, code "should" work.)

2. Rainfall is slow.

3. Config file: Save the state of flow across server stop/start (EDIT: Current!)

4. Config file: Record what we think is "sea level" in each dimension seen; permit user overrides.

5. Prevent diagonal flow through walls (if both direct flows are solid)

5b. Just stop the diagonal flow completely (Easy; I think vanilla water will flow diagonal? EDIT: Vanilla gives the appearance of diagonal flow. About 4 blocks or so diagonally)

6. Record actual fluid level across chunk save/reload.

... That's actually the priority list as well as the todo list :-).

Features, in some order:

1. Absorption / seepage / rainfall cycle. Right now you won't get puddles in the mountains, for example; you'll have a little bit of water on a ledge forever.

2. Figure out something for the nether and restoring lava as it is consumed. (Still looking for a good answer)

3. When no players are logged on, get a list of all loaded chunks, and process flowing water in all of them.

Aaannd, I found out how it can happen. In some cases, a block change task is delayed until later.

This mean that a vine can grow into a space that once was air, _THEN_ water attempts to flow into a space that is no longer air.

Argh. Asynch code.

EDIT: Or not? All of the calls to this routine say "do it now"; the delay for later flag is never "false". The "delay for later" code should never happen.

Hows your sanity Keybounce? I hope you have something hard to drink! Awesome work!

Drink? Yes.

Coffee, and a water flood :-)

New tool: gitflow. No, not water flow, but workflow/branching control.

Ok, alpha 5.0 is now ready.

Primary feature: Faster. It logs messages at 30,000 blocks per update; it aborts at 45,000 blocks per update. I can manage 30K+ without any slowdowns.

NEAR can, and should be, -1 (to disable). FAR can be 6 chunks (that's what I use).

NB: Rainfall is slow; it is not optimized.

This release should not have too much spam in it.

http://minecraft.curseforge.com/projects/realistic-fluids-overhaul-compatibility-and/files

** KNOWN INCOMPATIBILITY: ChromaticCraft. This will flood the ocean temples, and ruin them. Let Reika know you'd like to see a change in the ocean temple entrances to block the flow.

Correct. I'm so used to looking at the code.

Grumble grumble grumble tabs vs spaces grumble tab stop 4 grumble grumble ECLIPSE IS SET TO USE SPACES WHY ARE THERE TABS grumble grumble fixing this will make tons of stupid changes grumble grumble

Config file update to store the current state of enable flow setting: Working.

Usefulness, as soon as I want to extend that to store sea level on a per-dimension basis: Worthless.

This needs to be saved per-save/per-world, not in the config file. You might have one dimension with a sea level of 62 in one save, and 50 in another save (island world vs standard world).

Need to read up on "WorldSavedData". Not tonight.

Narrgh! Either this profiling tool (visualVM) is lying, or the rainfall code isn't taking up any significant time -- which means it is generating a state that is causing problems for the fluid flow on the next loop.

uggh ... well, at least I found a bug. Fluid levels are wrong during rainfall placement of water. Now, lets see if I can figure out what this bug would wind up doing.

Looks like at least some rainfalls are resulting in lost tracking of the block for some reason. Odd, because I see two places where it should trigger neighbor updates. EIDT: Yep, confirmed -- rainfall loses some updates. GRR.

... Ok, it's definitely a bug, but as far as I can tell, it's still calculating and doing what it should be. Still, it's a one-line fix.

... and at least got a first attempt at adjusting sea level based on world/dimension...

(Well, at least it's now in one spot, it's own routine, and it clearly inputs gAGL and outputs seaLevel.)

I hate java.

Quick question: In integer math, what is (-8 / n), where n is much bigger than -8?

Well, up to n=256, it's -1.

At n=512, it's 0.

I have code expecting the rounding to actually *work* at n=(1<<20).

Argh.

Well, I have confirmed: Lists of blocks that need to be updated are lost across chunk unload.

That -- plus detailed per-block fluid levels -- needs to be saved.

Keep in mind: This can be several hundred blocks per chunk, easily. Trivially in ocean-connected caves/ravines.

Rain bugs squashed, fluid level mismatch fixed, other problems continue to be found and ...

Putting rain the air (instead of on the ground) for debugging was interesting. I actually thought I'd want to keep it in the air, that it falls down from the clouds or something. But with lost updates happening ...

Great Job! ....don't keep a sledge hammer or anything that can smash things to bits near by....might be bad!

Awesome job keep up the great work!

thank you.

===

4Head: How is Lava supposed to flow? One lava block in the overworld will cover 4 to 8 spaces, maybe getting 2 blocks away from where it was placed, and that's all. It's also thick -- I thought the code would try to put half of the liquid into an empty air block, but it clearly is not.

In the nether: Updates are SLOW. Lava flow in the nether is painful. I can do R=6 (13x13) in the overworld, even in the ocean, but r=3 (7x7) in the nether is slow. I can't understand your visocity code, and I don't see anything obvious for causing lava slowness.