Developing a pack for 1.7.10. Using an old mod called Brewcraft. The mod looks like it's abandoned by the devs. Hasn't seen an update since 2015, nor any recent posts/comments/ticket replies, suggesting the devs aren't maintaining it anymore.
The mod works fine for the most part, except on a server. Due to the nature of my modpack, it's essential this mod works on a server.
The issue is that when splash potions from this mod are thrown on a server, the server crashes. Works fine on single player though.
I don't know enough about modding to fix this myself, but from what I can tell, it's a render issue. Brewcraft appears to have a client proxy, but no server proxy, so I *think* that it's trying to render splash potions on the server-side and thus crashing.
The mod license is CC, no deriv, but it's private use, so between that and the fact it has been abandoned, a privately used 'fixed' version should be fine license-wise. Just looking for someone who can be a god-send and fix this mod for me so it works properly on a server. You can PM me the fixed version.
Edit: Someone on our pack dev team looked at the source code. We made a change to the mod which kinda of but not really "fixed" the crash on the server side, but fatal errors are still thrown to the client when splash potions are tossed. It's a temporary soft fix (server won't crash, but client will), but obviously needs a better fix so that players don't get DCed when they toss them.
This bandaid fix was done by changing line 58 on the linked page below to
I'm willing to give this a try, have you attempted contact with the original creator directly? I'm all for keeping mods updated and working but if a developer does have plans to come back and update then I'd rather not intrude. You have mentioned the CC license but reading their terms as well they request being known about any publicly available modpacks. From your post I haven't noticed if the modpack will be used privately or publicly available.
Just let me know please.
Regards,
KnightDemon.
Rollback Post to RevisionRollBack
Working on several mods, some are Bleach, Jojo's Bizarre Adventure, Medacraft, Legacy of Kain, Jak and Daxter.
I'm willing to give this a try, have you attempted contact with the original creator directly? I'm all for keeping mods updated and working but if a developer does have plans to come back and update then I'd rather not intrude. You have mentioned the CC license but reading their terms as well they request being known about any publicly available modpacks. From your post I haven't noticed if the modpack will be used privately or publicly available.
Just let me know please.
Regards,
KnightDemon.
I've attempted to contact them indeed. I've both reported this issue on their Github and notified them on the MCForum page. From the looks of it, the mod hasn't seen any activity in well over a year, with no indication that there are plans to keep it alive. It's radio silence from the devs, basically.
At that, I do plan to notify the devs I'm using the mod, and have made fixes to it.
Okay, so I'm attempting to fix it now, sort of set it up but only just now realised that the Github has several versions on it, and downloading the master file doesn't help if I can't match up the Core master file as well.
SO, I need to know which version of Red Gear Core you're using, then I can get that one and then work to make BrewCraft compatible with that version, then fix any possible bugs I find.
I won't be able to update the mod beyond 1.7.10 if you were hoping for a future version, several reasons, 1, my laptop is not able to install 1.8 and up of the forge code to mod with, and 2. I don't have the expertise to do this nor update the Core which is what BrewCraft relies on.
Thank you for the quick reply as well, shame they aren't communicating, but I will delete all code if they request me to, but it is also an open sourced mod.
Rollback Post to RevisionRollBack
Working on several mods, some are Bleach, Jojo's Bizarre Adventure, Medacraft, Legacy of Kain, Jak and Daxter.
I need to know which version of Red Gear Core you're using
Looks like I'm using RedGearCore 2.2.2
I won't be able to update the mod beyond 1.7.10
Of course! I highly doubt my modpack will ever get updated past 1.7.10, since I'm using quite a few mods that have also been abandoned in this version. Again, all that I needed was a fix to prevent a crash.
Great... looking at the "releases" for the Github, it would appear they either didn't update the released versions of the Core with the new version numbers OR that hasn't become available yet. The Github says "2.1.3" but it does have a pull request about a 2.2.2 version of Red Gear Core, so they must have done something.
Either way what I'm going to have to do is just work from the Master they have on Github, and get to a point where I can build the mod and "release". From there we'll see if it works on the version you have. Wish me luck.
Rollback Post to RevisionRollBack
Working on several mods, some are Bleach, Jojo's Bizarre Adventure, Medacraft, Legacy of Kain, Jak and Daxter.
For those curious about permission, I found this comment by the dev from 2 years ago. Seems like they're ok with people fixing its bugs, since the dev retired from modding.
The Meaning of Life, the Universe, and Everything.
Location:
Colorado
Join Date:
3/27/2016
Posts:
208
Location:
Colorado
Minecraft:
ProfessorOro
Discord:
gargatheoro
PMC:
GargatheOro
Member Details
IKR I wanna use this mod too. I am an amateur sry I can't fix this What I do though is weapons. Custom knockback, range, and possibly cooldowns thanks to electroblob_. You might want to consider having electroblob's wizardry in your modpack.
IKR I wanna use this mod too. I am an amateur sry I can't fix this What I do though is weapons. Custom knockback, range, and possibly cooldowns thanks to electroblob_. You might want to consider having electroblob's wizardry in your modpack.
I have Minefantasy2 in the pack, which does add a few new combat mechanics, but nothing too overhaul-y.
Anywho, thanks for the interest. This mod is still open to be fixed for anyone out there willing. Unfortunately I can't even release my modpack until this is fixed, due to how severe/disruptive the issue is, so *any* help is appreciated!
Hey all,
Developing a pack for 1.7.10. Using an old mod called Brewcraft. The mod looks like it's abandoned by the devs. Hasn't seen an update since 2015, nor any recent posts/comments/ticket replies, suggesting the devs aren't maintaining it anymore.
The mod works fine for the most part, except on a server. Due to the nature of my modpack, it's essential this mod works on a server.
The issue is that when splash potions from this mod are thrown on a server, the server crashes. Works fine on single player though.
I don't know enough about modding to fix this myself, but from what I can tell, it's a render issue. Brewcraft appears to have a client proxy, but no server proxy, so I *think* that it's trying to render splash potions on the server-side and thus crashing.
The mod license is CC, no deriv, but it's private use, so between that and the fact it has been abandoned, a privately used 'fixed' version should be fine license-wise. Just looking for someone who can be a god-send and fix this mod for me so it works properly on a server. You can PM me the fixed version.
Here is the mod: https://mods.curse.com/mc-mods/minecraft/brewcraft
And the Git: https://github.com/RedGear/Brewcraft
And a crash report when splash potions from Brewcraft are thrown on a server: https://pastebin.com/raw/W7wJEPmJ
Thanks!
Edit: Someone on our pack dev team looked at the source code. We made a change to the mod which kinda of but not really "fixed" the crash on the server side, but fatal errors are still thrown to the client when splash potions are tossed. It's a temporary soft fix (server won't crash, but client will), but obviously needs a better fix so that players don't get DCed when they toss them.
This bandaid fix was done by changing line 58 on the linked page below to
https://github.com/RedGear/Brewcraft/blob/master/src/main/java/redgear/brewcraft/entity/EntityBrewcraftPotion.java
This might help you - looks like something is making the splash potions null, but not sure what or why.
I don't have much but, willing to pay for your efforts!
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumChange your Changes "if(potion != null)" to this if(entity != null). Maybe it helps.
Tried it, and still causes fatal error.
Here is the client console error:
https://pastebin.com/4YtYTjEH
Still looking for help! Thanks
Still open for assistance, thanks
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI'm willing to give this a try, have you attempted contact with the original creator directly? I'm all for keeping mods updated and working but if a developer does have plans to come back and update then I'd rather not intrude. You have mentioned the CC license but reading their terms as well they request being known about any publicly available modpacks. From your post I haven't noticed if the modpack will be used privately or publicly available.
Just let me know please.
Regards,
KnightDemon.
Working on several mods, some are Bleach, Jojo's Bizarre Adventure, Medacraft, Legacy of Kain, Jak and Daxter.
I've attempted to contact them indeed. I've both reported this issue on their Github and notified them on the MCForum page. From the looks of it, the mod hasn't seen any activity in well over a year, with no indication that there are plans to keep it alive. It's radio silence from the devs, basically.
At that, I do plan to notify the devs I'm using the mod, and have made fixes to it.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumOkay, so I'm attempting to fix it now, sort of set it up but only just now realised that the Github has several versions on it, and downloading the master file doesn't help if I can't match up the Core master file as well.
SO, I need to know which version of Red Gear Core you're using, then I can get that one and then work to make BrewCraft compatible with that version, then fix any possible bugs I find.
I won't be able to update the mod beyond 1.7.10 if you were hoping for a future version, several reasons, 1, my laptop is not able to install 1.8 and up of the forge code to mod with, and 2. I don't have the expertise to do this nor update the Core which is what BrewCraft relies on.
Thank you for the quick reply as well, shame they aren't communicating, but I will delete all code if they request me to, but it is also an open sourced mod.
Working on several mods, some are Bleach, Jojo's Bizarre Adventure, Medacraft, Legacy of Kain, Jak and Daxter.
Looks like I'm using RedGearCore 2.2.2
Of course! I highly doubt my modpack will ever get updated past 1.7.10, since I'm using quite a few mods that have also been abandoned in this version. Again, all that I needed was a fix to prevent a crash.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumGreat... looking at the "releases" for the Github, it would appear they either didn't update the released versions of the Core with the new version numbers OR that hasn't become available yet. The Github says "2.1.3" but it does have a pull request about a 2.2.2 version of Red Gear Core, so they must have done something.
Either way what I'm going to have to do is just work from the Master they have on Github, and get to a point where I can build the mod and "release". From there we'll see if it works on the version you have. Wish me luck.
Working on several mods, some are Bleach, Jojo's Bizarre Adventure, Medacraft, Legacy of Kain, Jak and Daxter.
Bump - still looking for someone to peer over this.
I did find some additional info that might help. Here's a client log that shows some errors regarding packets and handshake.
https://pastebin.com/DeAN9QgY
Still looking for help with this!
For those curious about permission, I found this comment by the dev from 2 years ago. Seems like they're ok with people fixing its bugs, since the dev retired from modding.
https://github.com/RedGear/Brewcraft/issues/18
IKR I wanna use this mod too. I am an amateur sry I can't fix this
What I do though is weapons. Custom knockback, range, and possibly cooldowns thanks to electroblob_. You might want to consider having electroblob's wizardry in your modpack.
An SF Towny server! Join our Discord: Click here
I have Minefantasy2 in the pack, which does add a few new combat mechanics, but nothing too overhaul-y.
Anywho, thanks for the interest. This mod is still open to be fixed for anyone out there willing. Unfortunately I can't even release my modpack until this is fixed, due to how severe/disruptive the issue is, so *any* help is appreciated!
No takers? =(