Minecraft Forums

so I'm trying to create an Item where you sneak+right click to charge it (to gives slowness), then you can use that charge to give movement speed.

Everything works except the NBT data is not unique. In other words, if I'm storing on one item, it stores on every item that has the NBT tag.

package com.mrdood.feruchemy.items;

import java.util.List;

import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.util.ChatComponentText;
import net.minecraft.world.World;


public class SteelMind extends Item{
	private int isTappingActive = 0;
	private int isStoringActive = 0;
	
	@Override
	public void onUpdate(ItemStack stack, World world, Entity player, int pInt, boolean b){
		NBTTagCompound nbt;
	    if (stack.hasTagCompound()){
	        nbt = stack.getTagCompound();
	    }
	    else{
	        nbt = new NBTTagCompound();
	    }
	    if(((EntityPlayer) player).getDisplayName().equals(nbt.getString("mindOwner"))){
	    	if(isStoringActive == 1 && nbt.getInteger("stored") < 1000){
	    		nbt.setInteger("stored", nbt.getInteger("stored") + 1);
	    		
				System.out.println("storing"+player);
				((EntityLivingBase) player).addPotionEffect(new PotionEffect(Potion.moveSlowdown.getId(),20,2));
		    }
		    if(isTappingActive == 1 && nbt.getInteger("stored") > 0){
		    	nbt.setInteger("stored", nbt.getInteger("stored") - 1);
				System.out.println("tapping"+player);
				((EntityLivingBase) player).addPotionEffect(new PotionEffect(Potion.moveSpeed.getId(),20,2));
		    }
	    }
	    
	}
	
	@Override
	public void onCreated(ItemStack stack,World world,EntityPlayer player){
		NBTTagCompound nbt;
		NBTTagCompound nbtp;
	    if (stack.hasTagCompound()){
	        nbt = stack.getTagCompound();
	    }
	    else{
	        nbt = new NBTTagCompound();
	    }
	    if(!nbt.hasKey("mindOwner")){
	    	nbt.setString("mindOwner", player.getDisplayName());
	    }
	    if(!nbt.hasKey("stored")){
	    	nbt.setInteger("stored",0);
	    }
	    
	    
	    stack.setTagCompound(nbt);
	}
	
	@Override
	public ItemStack onItemRightClick(ItemStack stack, World world, EntityPlayer player){
		if(!world.isRemote){
			NBTTagCompound nbt;
			if (stack.hasTagCompound()){
				nbt = stack.getTagCompound();
			}
			else{
				nbt = new NBTTagCompound();
			}
			if(!nbt.hasKey("mindOwner")){
				nbt.setString("mindOwner", player.getDisplayName());
			}
			if(!nbt.hasKey("stored")){
		    	nbt.setInteger("stored",0);
		    }
			
			stack.setTagCompound(nbt);
			
			if(player.isSneaking() && isStoringActive == 0 && isTappingActive == 0 && nbt.getInteger("stored") < 1000){//storing
				isStoringActive = 1;
				isTappingActive = 0;
			}else if(!player.isSneaking() && isStoringActive == 0 && isTappingActive == 0 && nbt.getInteger("stored") > 0){//tapping
				isStoringActive = 0;
				isTappingActive = 1;
			}else{
				isStoringActive = 0;
				isTappingActive = 0;
			}
		}
		return stack;
	}
	
	@SuppressWarnings({"unchecked","rawtypes"})
	@Override
	public void addInformation(ItemStack stack,EntityPlayer player,List lores,boolean b){
		if(stack.hasTagCompound() && stack.getTagCompound().hasKey("mindOwner")){
			lores.add("Owner: "+stack.getTagCompound().getString("mindOwner"));
			lores.add("Speed Stored: "+(stack.getTagCompound().getInteger("stored")/10.0)+"%");
		}
	}
}

here is the code for the class.

any suggestions?

The intended functionality is a player Shift+right clicks the item, it starts storing nbt data just to that item, then they stop storing by clicking again. Then, as long as they have over 0 in charge (nbt value), they can click while not sneaking to use charge. When a player is storing charge, that player should get slowness and when they are using charge, that player should get speed.

EDIT: solved