Minecraft Forums

Can you show us the complete TE class?

Damn sorry I got confused.

Anyways, you forgot to override the writetonbt and readfromnbt methods, that might be why the value isn't actually getting changed within the TE. However, you most likely do not need to store that data if you only change the texture if regarding the power level. You can access that data through this snippet:

te.getWorldObj().getBlockPowerInput((int)x, (int)y, (int)z)

It will avoid you having to save and write data all the time and willbe overall more effective.

Look at the facing variable in the following code I use: https://github.com/Ferdzz/PlaceableItems/blob/master/src/main/java/com/stuntmania/placeableitems/tileentity/TEPlaceableItems.java#L41-L51 it's just a matter of storing the data in the nbt tag. That might be the problem.

If you are overriding the writeToNBT and readFromNBT methods, you should put this.markDirty() in every setter method so any changes are saved.

Besides that, here is why your texture is not changing:

public TileEntityVerticalTrafficLight te = new TileEntityVerticalTrafficLight();

You put this in your Block class. Two things: All Blocks are a single instance, so you are accessing a single instance of your TileEntity. However, all Entity classes (including TileEntity) are initialized separately by using the createNewTileEntity method you override. Basically, you're setting the values for te but accessing the values from another instance.

Do not do that. You can access the actual TileEntity, the one that the Renderer checks for values, with this:

TileEntityVerticalTrafficLight tevtl = (TileEntityVerticalTrafficLight)world.getTileEntity(x,y,z);

Use that in onNeighborBlockChange instead of making a class variable to hold one universal TileEntity that, as far as the game is concerned, has no location and therefore does not exist in the world. You may also consider casting to TileEntityVerticalTrafficLight only after an instanceof check.

What do your printouts say the values are?

Add a printout to onNeighborBlockChange to state what the power level is AND what TileEntityVerticalTrafficLight#getPower returns.

Also add a printout to the renderer to see what it thinks the TileEntity power level is (warning: printouts in the renderers spam the console logs)

Hmmmm... I'm at a loss. Experiment while I think of something and one of us will solve it

Aha got it! You made the same mistake in the Renderer by accessing a TileEntity instance that is never changed:

public TileEntityVerticalTrafficLight te = new TileEntityVerticalTrafficLight();
.......
// then in your renderTileEntityAt method you're given tileentity but use te
if (te.getPower() == 0)
.....

You need to learn about casting. Up-casting is when you tell Java to assume that the TileEntity passed in by renderTileEntityAt is actually a TileEntityVerticalTrafficLight. That will let you access getPower() by using the actual TileEntity that the renderer is checking

I do this at the beginning of my methods:

@Override
public void renderTileEntityAt(TileEntity te, double x, double y, double z, float par5) 
{
	final float SC = 0.0625F;
	if(te instanceof TETesla)
	{
		TETesla tesla = (TETesla)te; // now you can use it!
		GL11.glPushMatrix();
		// bind texture
		int frame = getFrame(tesla.getTicks()); // here I use the casted version
		this.bindTexture(textures[frame]);
		// set location
		GL11.glTranslatef((float) x + 0.5F, (float) y + 1.5F, (float) z + 0.5F);
		// rotate so it's not upside down
		GL11.glPushMatrix();
		GL11.glRotatef(180F, 0.0F, 0.0F, 1.0F);
			
		this.model.render(null, 0, 0, 0, 0, 0, SC);
		GL11.glPopMatrix();	
		GL11.glPopMatrix();
	}
}

What's your new Block class? In particular I need to make sure you did onNeighborBlockChange right. You should be using something like this to set the TileEntity power level:

TileEntity te = world.getTileEntity(x, y, z);
if(te instanceof TileEntityVerticalTrafficLight)
{
 TileEntityVerticalTrafficLight tevtl = (TileEntityVerticalTrafficLight)te;
 if (world.isBlockIndirectlyGettingPowered(x, y, z))
 {
   tevtl.setPower(1);
 }      
 else
 {
   tevtl.setPower(0);
   System.out.println("Power should be 0");
   System.out.println("TE power returns " + tevtl.getPower());
 } 
}

If the TileEntity has the right information, your Renderer should now work perfectly. Only thing I can think of is that the TileEntity has the wrong information somehow.

Quote from TheBoeing767fan»

I had something similar to yours, but I copied over your code and still no avail...

What could be wrong?

Does it need a method to initiate a render update?