I'm using onUpdate to try and give an item two enchantments. The Item is uncraftable, found only in random Stasis Boxes that generate buried under the ground. However, once I get one from the box, it never enchants, should I only be giving it on enchant or can I do multiple enchants?
package projectmayhem1983.wheeloftime.item;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemSword;
import net.minecraft.world.World;
public class ItemHeronSword extends ItemSword {
public ItemHeronSword(ToolMaterial material) {
super(material);
this.setFull3D();
}
public void onUpdate(ItemStack stack, World world, EntityPlayer player) {
if (!stack.isItemEnchanted()) {
stack.addEnchantment(Enchantment.sharpness, 3);
stack.addEnchantment(Enchantment.unbreaking, 3);
}
}
}
I do not know if you need to know how the sword is generating , but here is the code from my stasis box that generates a random item. From what I've been reading on the forums and seen from watching tutorials, this should work. Unless I should be using just one enchantment, right?
Your onUpdate method doesn't override Item#onUpdate because it has the wrong signature (name, number of arguments and argument types). The signature of Item#onUpdate is onUpdate(ItemStack,World,Entity,int,boolean).
I suggest adding the @Override annotation to any override method so you get a compiler error if it doesn't actually override a method of the superclass. This tutorial explains method overriding in more detail.
Your IDE should also be able to auto-generate override methods for you.
I wouldn't really recommend applying the enchantments from Item#onUpdate, you should just add the enchantments to the ItemStack before you add it to your ChestGenHooks. You could also override Item#getChestGenBase to apply the enchantments, this is called whenever a ChestGenHooks generates your item.
Rollback Post to RevisionRollBack
Chisel Facades: For all your decorative pipe-hiding needs.
Please don't PM me to ask for help or to join your mod development team. Asking your question in a public thread preserves it for people who are having the same problem in the future. I'm not interested in developing mods with people.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI'm using onUpdate to try and give an item two enchantments. The Item is uncraftable, found only in random Stasis Boxes that generate buried under the ground. However, once I get one from the box, it never enchants, should I only be giving it on enchant or can I do multiple enchants?
package projectmayhem1983.wheeloftime.item; import net.minecraft.enchantment.Enchantment; import net.minecraft.entity.player.EntityPlayer; import net.minecraft.item.ItemStack; import net.minecraft.item.ItemSword; import net.minecraft.world.World; public class ItemHeronSword extends ItemSword { public ItemHeronSword(ToolMaterial material) { super(material); this.setFull3D(); } public void onUpdate(ItemStack stack, World world, EntityPlayer player) { if (!stack.isItemEnchanted()) { stack.addEnchantment(Enchantment.sharpness, 3); stack.addEnchantment(Enchantment.unbreaking, 3); } } }I do not know if you need to know how the sword is generating , but here is the code from my stasis box that generates a random item. From what I've been reading on the forums and seen from watching tutorials, this should work. Unless I should be using just one enchantment, right?
package projectmayhem1983.wheeloftime.init; import net.minecraft.init.Blocks; import net.minecraft.init.Items; import net.minecraft.item.ItemStack; import net.minecraft.util.WeightedRandomChestContent; import net.minecraftforge.common.ChestGenHooks; public class WheelOfTimeStasisBox { public static final ChestGenHooks RIGHT_CLICK_LOOT_BLOCK = ChestGenHooks.getInfo("wot:Stasis Box"); public static void initLoot() { RIGHT_CLICK_LOOT_BLOCK.setMin(5); RIGHT_CLICK_LOOT_BLOCK.setMax(20); // new WeightedRandomChestContent(item, minAmount, maxAmount, weight) RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.fishing_rod), 1, 1, 10)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.map), 1, 1, 10)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(WheelOfTimeItems.itemFountainta), 1, 1, 1)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.diamond), 1, 3, 5)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.emerald), 1, 3, 5)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.apple), 1, 5, 10)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.arrow), 1, 15, 10)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.blaze_rod), 1, 1, 5)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.book), 1, 15, 10)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.clock), 1, 1, 10)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.compass), 1, 1, 10)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.diamond_axe), 1, 1, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.diamond_sword), 1, 1, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.diamond_hoe), 1, 1, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.diamond_pickaxe), 1, 1, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.diamond_boots), 1, 1, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.diamond_chestplate), 1, 1, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.diamond_helmet), 1, 1, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.diamond_leggings), 1, 1, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.experience_bottle), 1, 20, 10)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Blocks.daylight_detector), 1, 1, 20)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(WheelOfTimeTools.powerAxe), 1, 1, 10)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(WheelOfTimeTools.heronsword), 1, 1, 100)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.fireworks), 1, 20, 20)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(WheelOfTimeTools.ashandarei), 1, 1, 1)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.golden_carrot), 1, 5, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Items.golden_apple), 1, 5, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(Blocks.diamond_block), 1, 1, 1)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(WheelOfTimeItems.itemAngelta), 1, 1, 1)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(WheelOfTimeItems.itemFountainta), 1, 1, 1)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(WheelOfTimeBlocks.blockCuendillar), 1, 1, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(WheelOfTimeArmor.whitecloakChest), 1, 1, 3)); RIGHT_CLICK_LOOT_BLOCK.addItem(new WeightedRandomChestContent(new ItemStack(WheelOfTimeTools.powerSword), 1, 1, 3)); } }Your onUpdate method doesn't override Item#onUpdate because it has the wrong signature (name, number of arguments and argument types). The signature of Item#onUpdate is onUpdate(ItemStack,World,Entity,int,boolean).
I suggest adding the @Override annotation to any override method so you get a compiler error if it doesn't actually override a method of the superclass. This tutorial explains method overriding in more detail.
Your IDE should also be able to auto-generate override methods for you.
I wouldn't really recommend applying the enchantments from Item#onUpdate, you should just add the enchantments to the ItemStack before you add it to your ChestGenHooks. You could also override Item#getChestGenBase to apply the enchantments, this is called whenever a ChestGenHooks generates your item.
Chisel Facades: For all your decorative pipe-hiding needs.
Please don't PM me to ask for help or to join your mod development team. Asking your question in a public thread preserves it for people who are having the same problem in the future. I'm not interested in developing mods with people.