It can work for fish very well: EntityFish has one final field: type. This is variable FishType, which gets generated from json. When it's time to spawn a fish a random fish type gets selected which will work for spawn position (biome, height...), then new EntityFish(randomTypeThatWorksInThisLocation). Then spawn it. Now, all parameters that you allow to be changed in fishes (bb size, baits types, model, texture, ...) are specified in FishType, and all calls to these getter methods get redirected to fishType. Which is specified from Json! Last thing: to save fish type, just save type name, because fish types, like items and blocks, are singletons...
This is one of ways of how this can work...
Again, if you will not make json, but will make an api, i can write json-api hook to do these things...
Ah, that's a good plan.
You're going to have to write your own renderer if you want to support multiple models for one fish entity (though I'm not entirely sure how you would add entity models through json), but it would work. You'll also need to add your own spawn egg items and fish buckets.
I think I'll stick with adding a code api for now, but once I get that done, you can go crazy and add all the json you want. =P
hello, I just wanted to pop by and say "nice mod" before offering my input on it.
it is a very nice mod, but personally I would like to see not only the ability to toggle fishbones on and off, but the chance of catching an actual fish item instead of fishbones, sort of like a junk catch but on fish. on a secondary note, a way of linking it to the "config" button in the mods menu would be appreciated, if possible.
I have yet to try the new rods as of yet, though it does look interesting.
Hmm, I actually can't really do the config button, since all the current config things need to run as the game starts. As for having a chance of still catching fish, I'd rather keep that a toggle on or off for this mod, but I'm planning to add the fish loot to my Loot++ mod now that I know more about it, so you will be able to modify it there eventually (add it back and specify exact probabilities).
You're going to have to write your own renderer if you want to support multiple models for one fish entity (though I'm not entirely sure how you would add entity models through json), but it would work. You'll also need to add your own spawn egg items and fish buckets.
I think I'll stick with adding a code api for now, but once I get that done, you can go crazy and add all the json you want. =P
I've released a new update! The only differences are a fix for the tank blocks crashing on servers, and a couple other tweaks and fixes.
For the Optifine bug, here's some more info:
The fish entities can't move at all within 8 or so blocks from you. Beyond that, they act as they should. If you try to fish them up or push them within those 8 blocks, they kinda glitch around and pop back in place. I haven't found the cause nor the solution, but have messaged the creator of Optifine, so hopefully he can help get some answers.
Until then, I've added an option in the config file called "Simple Fishing", which if you are having issues, you should set to true. It makes it so that if you hook a fish, it catches it immediately, without doing the reeling. So you should set that option to true and cast your rods quite far away (more than 8 blocks), so the fish can swim to them without bugging out.
I've released a new update! The only differences are a fix for the tank blocks crashing on servers, and a couple other tweaks and fixes.
For the Optifine bug, here's some more info:
The fish entities can't move at all within 8 or so blocks from you. Beyond that, they act as they should. If you try to fish them up or push them within those 8 blocks, they kinda glitch around and pop back in place. I haven't found the cause nor the solution, but have messaged the creator of Optifine, so hopefully he can help get some answers.
Until then, I've added an option in the config file called "Simple Fishing", which if you are having issues, you should set to true. It makes it so that if you hook a fish, it catches it immediately, without doing the reeling. So you should set that option to true and cast your rods quite far away (more than 8 blocks), so the fish can swim to them without bugging out.
Thank you so much! Will this fix that issue where the fish didn't move? It makes me wonder if the optifine dude has some sort of like "optimization" that makes entities do that from 8 blocks away, if so, I wonder if there is a way to disable it.
Thank you so much! Will this fix that issue where the fish didn't move? It makes me wonder if the optifine dude has some sort of like "optimization" that makes entities do that from 8 blocks away, if so, I wonder if there is a way to disable it.
Yeah, I've been playing with the options and haven't been able to get the fish moving. The Light version of optfine doesn't affect them. I forgot to mention that. Maybe there's something that's supposed to make far away entities not move (for optimization, like you said). But it definitely shouldn't be happening when you're right beside the entity... and it definitely doesn't happen like that for any other entities.
The "fix" (which isn't a fix =P) above is just if you hook a fish, as soon as you pull on the rod, from any distance, it catches the fish. That way you don't have to sit there and try reeling in the glitchy fish... Hopefully I can get an actual fix for the problem...
Yeah, I've been playing with the options and haven't been able to get the fish moving. The Light version of optfine doesn't affect them. I forgot to mention that. Maybe there's something that's supposed to make far away entities not move (for optimization, like you said). But it definitely shouldn't be happening when you're right beside the entity... and it definitely doesn't happen like that for any other entities.
The "fix" (which isn't a fix =P) above is just if you hook a fish, as soon as you pull on the rod, from any distance, it catches the fish. That way you don't have to sit there and try reeling in the glitchy fish... Hopefully I can get an actual fix for the problem...
Yeah, its really cheaty on my survival modpack, because whats the point of fishing if you can just walk up to the fish and catch them?
Ah. Yeah, though you still do have to wait for a fish to swim to your hook, and then do it, so it's not much different from vanilla fishing then. =P
You could also use the Optifine Light if that works for your modpack, since it doesn't glitch in that verison.
Isn't optifine light incompatible with forge? Also, a big reason I use optifine is for the natural textures part ( where textures are randomly flipped to remove the grid-like pattern. )
Isn't optifine light incompatible with forge? Also, a big reason I use optifine is for the natural textures part ( where textures are randomly flipped to remove the grid-like pattern. )
Ah, I see. Nope, I tested with the light version, which definitely worked. Well, hopefully I can get to the bottom of whatever is causing the issue eventually.
Just wanted to pop on here real quick to say thanks for another wonderful mod. I just started up a new singleplayer world and was setting up my starter base near a lake when I noticed a few 'familiar' fishes swimming around. As I was tossing some of my rubbish in the water (flowers, seeds, etc), one of the fish swam by real fast and took a little nibble from the stack of items. At least, I think that's what it did because I noticed some love hearts as it swam away. Then shortly thereafter, another one of them came close and hopped onto the gravel and started flopping around, so I nudged the little guy back in the water. I haven't even tried the fishing mechanic yet, but from what I've seen so far, I'm absolutely loving this mod!
Lol, yeah. The fish will eat seeds that you throw in the water (which is how you breed them). I'm glad you're enjoying the mod. =)
I cant seem to catch any actual fish do they have to catch the enity? or willl it work with no enitys in the water
Yeah, you have to find and catch the actual fish entities. Keep in mind that once you find two, you can always make a farm and breed them to get more. =)
Wow, this mod is exactly how I think MC fishing should be!
Sadly, I recently moved to 1.8 :/
I have a new account called "Mushroomsock" now, so please do not send me PMs.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAh, that's a good plan.
You're going to have to write your own renderer if you want to support multiple models for one fish entity (though I'm not entirely sure how you would add entity models through json), but it would work. You'll also need to add your own spawn egg items and fish buckets.
I think I'll stick with adding a code api for now, but once I get that done, you can go crazy and add all the json you want. =P
Hmm, I actually can't really do the config button, since all the current config things need to run as the game starts. As for having a chance of still catching fish, I'd rather keep that a toggle on or off for this mod, but I'm planning to add the fish loot to my Loot++ mod now that I know more about it, so you will be able to modify it there eventually (add it back and specify exact probabilities).
Ah, well, I'm going to be updating to 1.8 once I get the mod a bit more stable. So check back later. =)
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI definetly will
...
Check out all my mods here: Link Removed!
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumHey everyone!
I've released a new update! The only differences are a fix for the tank blocks crashing on servers, and a couple other tweaks and fixes.
For the Optifine bug, here's some more info:
The fish entities can't move at all within 8 or so blocks from you. Beyond that, they act as they should. If you try to fish them up or push them within those 8 blocks, they kinda glitch around and pop back in place. I haven't found the cause nor the solution, but have messaged the creator of Optifine, so hopefully he can help get some answers.
Until then, I've added an option in the config file called "Simple Fishing", which if you are having issues, you should set to true. It makes it so that if you hook a fish, it catches it immediately, without doing the reeling. So you should set that option to true and cast your rods quite far away (more than 8 blocks), so the fish can swim to them without bugging out.
Thank you so much! Will this fix that issue where the fish didn't move? It makes me wonder if the optifine dude has some sort of like "optimization" that makes entities do that from 8 blocks away, if so, I wonder if there is a way to disable it.
(insert cringy dubstep minecraft intro here)
I certainly will.
I have a new account called "Mushroomsock" now, so please do not send me PMs.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumYeah, I've been playing with the options and haven't been able to get the fish moving. The Light version of optfine doesn't affect them. I forgot to mention that. Maybe there's something that's supposed to make far away entities not move (for optimization, like you said). But it definitely shouldn't be happening when you're right beside the entity... and it definitely doesn't happen like that for any other entities.
The "fix" (which isn't a fix =P) above is just if you hook a fish, as soon as you pull on the rod, from any distance, it catches the fish. That way you don't have to sit there and try reeling in the glitchy fish... Hopefully I can get an actual fix for the problem...
Yeah, its really cheaty on my survival modpack, because whats the point of fishing if you can just walk up to the fish and catch them?
(insert cringy dubstep minecraft intro here)
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAh. Yeah, though you still do have to wait for a fish to swim to your hook, and then do it, so it's not much different from vanilla fishing then. =P
You could also use the Optifine Light if that works for your modpack, since it doesn't glitch in that verison.
Isn't optifine light incompatible with forge? Also, a big reason I use optifine is for the natural textures part ( where textures are randomly flipped to remove the grid-like pattern. )
(insert cringy dubstep minecraft intro here)
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAh, I see. Nope, I tested with the light version, which definitely worked. Well, hopefully I can get to the bottom of whatever is causing the issue eventually.
I really like this mod. Its pretty awesome! I put it into my new pack! Thank you for it!
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumHey, looks good! I hope it goes well. =)
Just wondering how would I go about changing how the tank looks to make the it more Clear, no little white dots like a normal glass texture?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThe tank pulls it's texture directly from glass blocks, so you can create or install an existing resource pack that makes glass clearer.
I cant seem to catch any actual fish do they have to catch the enity? or willl it work with no enitys in the water
there are mobs that you have to catch other than that you will catch bones and loot...
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumLol, yeah. The fish will eat seeds that you throw in the water (which is how you breed them). I'm glad you're enjoying the mod. =)
Yeah, you have to find and catch the actual fish entities. Keep in mind that once you find two, you can always make a farm and breed them to get more. =)
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumhttp://hastebin.com/unobohunis.vhdl
I get this crash server side occasionally.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumHmm, do you happen to have a bukkit server?