all it chandes is the line
if(item instanceofnet.minecraft.item.ItemSpade){
to
if(item instanceofnet.minecraft.item.ItemSpade|| item.getHarvestLevel(newItemStack(item), "shovel") !=-1){
Got it! Thanks TheOldOne! I'll publish a new version after I also increase the inventory size.
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
can you please make the body to not be damaged by water i know that water don't inflict damage but they keep making damage sounds and this make my game lag and is annoying
Well, it seems this is already a decent bit outdated, but here is that Mod Spotlight I mentioned before =P I already added an annotation about the Death Lag issue, but let me know if there is anything else I should note.
New updated version 1.2.0! Now with more inventory space! The default is 108 item stacks, but it is configurable up to truly absurd inventory capacities. I also applied the patch to use shovel-like tools from other mods to dispose the body and fixed the drowning noises problem.
I was unable to create a tabbed GUI like I originally intended, so I instead created an invisible buffer of extra items that automatically appear in the GUI as you pull items out (it is akin to pulling items from a chest with a hopper feeding into it). Even though the dead body can hold more than 100 items, you cannot manually add more than 54 items (its a corpse, not a storage chest).
To test out the new increased size, fill up a double-chest with stuff and then your own inventory. Then switch to survival mode (creative mode destroys extra items that you pick up) and break open the chest. While standing in the pile of items, use the /kill command. When looting your body, you will see items fill into the body inventory as you remove items until the hidden item buffer is empty.
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
Sounds amazing! I really like the sound of buffer while limiting the visible space to 54. I'll be sure to try it out soon; busy with another project atm. At this rate, I'll need to do a new mod spotlight in a month to cover all these amazing update XD
The Meaning of Life, the Universe, and Everything.
Location:
Victoria
Join Date:
1/9/2013
Posts:
43
Location:
Victoria
Minecraft:
glittertoxin
Member Details
hey dude. i love your mod. I had a request though. I am using your 1.7.10 release of this. I was wondering if you could include a "body disappears" timer on it when its down. or even just make it an option iny our config
if that makes the code a bit complicated. even an option of after like, 3-5 minutes, the body disappears kind of toggleable config for it. i am using it on my server, and i feel the bodies will clutter up after players just disregard them, or had no loot to begin with to go after that body.
At least this way, i can turn that option on, and they got like 5 minutes to go loot the body before it disappears completely.
its a chunk loading/keep open kind of thing is what i worry about, and bodies overloading the server.
thanks in advance. ive been messing around with it.
The dead bodies won't keep a chunk loaded, but they do use a small amount of processing and network resources when they in a loaded chunk. A decay timer seems to be a popular request, so I'll add it to the to-do list.
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
The Meaning of Life, the Universe, and Everything.
Location:
Victoria
Join Date:
1/9/2013
Posts:
43
Location:
Victoria
Minecraft:
glittertoxin
Member Details
thanks man. even a 5 minute timer or adjustable one to remove the entity altogether would be awesome. its great though. i like how it shows the player and everything. this would be great for a pvp server as well. so people can go corpse hunting.
5 minutes is no better than the default behavior in Minecraft. I'd think that 1hr would be a much more reasonable default setting for such a feature. It will be configurable when I add this feature, but I'm going to use a time format that makes it easy to enter time periods measured in hours (e.g. hr:min format).
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
Which version of Forge (entire version number) are you using when you get that error? It looks like you might be using the Lootable Bodies version for MC 1.8 on MC 1.7.10.
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
I don't know what you mean by plugin. This mod works on Forge servers as well as in single-player. Like all Forge mods, both the server and the clients need to have the same mods installed.
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
The Meaning of Life, the Universe, and Everything.
Join Date:
2/14/2014
Posts:
50
Member Details
me thinks he wants bukkit plugin and not forge mod
i like the new configurable size option, now you have someone suggesting to make it smaller
1 hr for some inventory, overflow goes to ground and 5 min decay
i dunno just seems neet for harder servers to not save 100%
and crash report for 1.8-1.1.2, inventory full but no reason it wouldnt have fit the old 54 slot, dont think its size issue
java.lang.StackOverflowError: Ticking entity at cyano.lootable.entities.EntityLootableBody.vacuumItem(EntityLootableBody.java:331) at cyano.lootable.entities.EntityLootableBody.vacuumItem(EntityLootableBody.java:331) at cyano.lootable.entities.EntityLootableBody.vacuumItem(EntityLootableBody.java:331) ...
Ahhh, the joys of recursive code.
I made it non-recursive in version 1.2.0, which also has a few bug fixes.
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
Hey, I was testing mods today and unfortunately ran into a pretty serious bug that related to lootable bodies. Long story short, I died with an item with 0 durability (its durability was RF charge and it was out of power); lootable bodies then lowered its durability to a negative number I guess, either way it made a glitch item that crashed my game. I did tests and it does seem like this is what happened, especially since when I turned durability loss to 0 I had no crashes.
I'm not sure how much you can do to prevent this, since I bet there are a lot of crazy mods that abuse durability. But if I had to guess, the mod stops durability at 1 and doesn’t have any safeguards for items with less than 1 durability (0 or negative). I think I'll just be leaving my durability loss on 0 for now though...
Hey, I was testing mods today and unfortunately ran into a pretty serious bug that related to lootable bodies. Long story short, I died with an item with 0 durability (its durability was RF charge and it was out of power); lootable bodies then lowered its durability to a negative number I guess, either way it made a glitch item that crashed my game. I did tests and it does seem like this is what happened, especially since when I turned durability loss to 0 I had no crashes.
I'm not sure how much you can do to prevent this, since I bet there are a lot of crazy mods that abuse durability. But if I had to guess, the mod stops durability at 1 and doesn’t have any safeguards for items with less than 1 durability (0 or negative). I think I'll just be leaving my durability loss on 0 for now though...
You're very perceptive. When you die, all damageable items put into your dead body are damaged, but the damage applied stops 1 point short of destroying the item (durability is calculated as max damage minus current damage). For items that are not marked as damageable, this isn't an issue, but if the item's damage is equal to or greater than the max damage value, then there's trouble.
Here's the actual code for damaging items:
_public static ItemStack applyItemDamage(ItemStack itemstack){
if (itemstack != null && itemstack.isItemStackDamageable()) {
final int newDamageValue = itemstack.getItemDamage() + additionalItemDamage;
itemstack.setItemDamage(Math.min(newDamageValue, itemstack.getMaxDamage() - 1));
}
return itemstack;
}
A vanilla Minecraft item with 0 durability breaks as soon as something causes the game to update that item's state. You report that some mods disable this behavior. So to fix this bug, I need an answer to this question: How can I determine whether or not an item with 0 (or negative) durability is considered broken using only the information stored in the ItemStack object?
Rollback Post to RevisionRollBack
My mods: Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
It is a used on git for pulling code one person has done into the base code.
I do know a way to do that and how to check nonstandard tools. link to PR if you need it https://github.com/cyanobacterium/DrCyanos_Lootable-Bodies/pull/2
all it chandes is the line
if(item instanceofnet.minecraft.item.ItemSpade){
to
if(item instanceofnet.minecraft.item.ItemSpade|| item.getHarvestLevel(newItemStack(item), "shovel") !=-1){
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
Mod Packs- Untamed Chaos (1.7.10), Moonlit Siege (1.7.10), Ascension (1.6.4)
Youtube- Minecraft Channel, Let's Plays (Ascension Hardcore, Proton), Mod Spotlights
I was unable to create a tabbed GUI like I originally intended, so I instead created an invisible buffer of extra items that automatically appear in the GUI as you pull items out (it is akin to pulling items from a chest with a hopper feeding into it). Even though the dead body can hold more than 100 items, you cannot manually add more than 54 items (its a corpse, not a storage chest).
To test out the new increased size, fill up a double-chest with stuff and then your own inventory. Then switch to survival mode (creative mode destroys extra items that you pick up) and break open the chest. While standing in the pile of items, use the /kill command. When looting your body, you will see items fill into the body inventory as you remove items until the hidden item buffer is empty.
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
Mod Packs- Untamed Chaos (1.7.10), Moonlit Siege (1.7.10), Ascension (1.6.4)
Youtube- Minecraft Channel, Let's Plays (Ascension Hardcore, Proton), Mod Spotlights
if that makes the code a bit complicated. even an option of after like, 3-5 minutes, the body disappears kind of toggleable config for it. i am using it on my server, and i feel the bodies will clutter up after players just disregard them, or had no loot to begin with to go after that body.
At least this way, i can turn that option on, and they got like 5 minutes to go loot the body before it disappears completely.
its a chunk loading/keep open kind of thing is what i worry about, and bodies overloading the server.
thanks in advance. ive been messing around with it.
Second I think you should add looting on mobs aswell, and to be able to choose what mobs in config.
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
It is a great mod and I love but I was wondering is there a plugin so we can use it on server and so on? like a plugin version of it ?
Thanks
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
i like the new configurable size option, now you have someone suggesting to make it smaller
1 hr for some inventory, overflow goes to ground and 5 min decay
i dunno just seems neet for harder servers to not save 100%
and crash report for 1.8-1.1.2, inventory full but no reason it wouldnt have fit the old 54 slot, dont think its size issue
http://pastebin.com/JtQUA5ZT
shame on you for the massive nested method calling!
Ahhh, the joys of recursive code.
I made it non-recursive in version 1.2.0, which also has a few bug fixes.
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes
Not doing mc modding that much anymore because I am making a full blown game that does not have limitations that mc has. (rip Magiology for now)
I may come back if MC fixes it's rendering pipeline.
I'm not sure how much you can do to prevent this, since I bet there are a lot of crazy mods that abuse durability. But if I had to guess, the mod stops durability at 1 and doesn’t have any safeguards for items with less than 1 durability (0 or negative). I think I'll just be leaving my durability loss on 0 for now though...
Mod Packs- Untamed Chaos (1.7.10), Moonlit Siege (1.7.10), Ascension (1.6.4)
Youtube- Minecraft Channel, Let's Plays (Ascension Hardcore, Proton), Mod Spotlights
You're very perceptive. When you die, all damageable items put into your dead body are damaged, but the damage applied stops 1 point short of destroying the item (durability is calculated as max damage minus current damage). For items that are not marked as damageable, this isn't an issue, but if the item's damage is equal to or greater than the max damage value, then there's trouble.
Here's the actual code for damaging items:
A vanilla Minecraft item with 0 durability breaks as soon as something causes the game to update that item's state. You report that some mods disable this behavior. So to fix this bug, I need an answer to this question: How can I determine whether or not an item with 0 (or negative) durability is considered broken using only the information stored in the ItemStack object?
My mods:
Base Metals, Power Advantage, Steam Advantage, Electric Advantage, Minecraft Mineralogy, Dr. Cyano's Lootable Bodies, Dr. Cyano's Wonderful Wands & Wizarding Robes