Well I've tried to port it over but I don't have any coding knowledge so I didn't know how to fix a lot of the errors to even compile it back into a jar file.
If there is an effort underway to port to 1.12, it might be worth considering if it could be done by subclassing and extending the existing player class instead of replacing it. The one drawback Smart Moving always had was that it was not compatible with third-party mod-added custom armors, or with other mods that modify the player such as Gender. There was the player class replacer add-on that made it work with third-party armors such as Thaumcraft's magnificent Thaumium Fortress armor, but that had bizarre side effects on things like Bibliocraft armor stands.
If there is an effort underway to port to 1.12, it might be worth considering if it could be done by subclassing and extending the existing player class instead of replacing it. The one drawback Smart Moving always had was that it was not compatible with third-party mod-added custom armors, or with other mods that modify the player such as Gender. There was the player class replacer add-on that made it work with third-party armors such as Thaumcraft's magnificent Thaumium Fortress armor, but that had bizarre side effects on things like Bibliocraft armor stands.
From what I know about coding, the author should have gone for third party integration from the beginning.
Replacing something that other mods are going to rely on is basically saying: "My mod is only mod you need!"
In cases like Terrafirmacraft, that might be true.
Here, it is not.
Plus I also wonder why the animations can't just be done like in the vanilla game.
They have basic walking animations there, smacking stuff and now even smimming.
Even if that stuff is hardcoded in, one would simply need to make the mod a coremod to replicate it and that oughta do the trick.
Correct me.
No, not *if* I am wrong. Because I surely am. Or else the original mod author would have done the way I just described
Rollback Post to RevisionRollBack
Yes, I AM a Vampire. Nice of you to notice.
Why is that box so big? What do you mean I should stop breaking the fourth wall?
If there is an effort underway to port to 1.12, it might be worth considering if it could be done by subclassing and extending the existing player class instead of replacing it. The one drawback Smart Moving always had was that it was not compatible with third-party mod-added custom armors, or with other mods that modify the player such as Gender. There was the player class replacer add-on that made it work with third-party armors such as Thaumcraft's magnificent Thaumium Fortress armor, but that had bizarre side effects on things like Bibliocraft armor stands.
smart moving is a mission critical mod in my opinion, visual only glitches aren't even an annoyance unless i hit f5 by mistake.
also there's been a very easy to use API that other mods could and should have been plugging into to fix that issue for YEARS, smart moving has already bent over backwards trying to help, screw them if they don't care enough to fix their problems.
smart moving is a mission critical mod in my opinion, visual only glitches aren't even an annoyance unless i hit f5 by mistake.
also there's been a very easy to use API that other mods could and should have been plugging into to fix that issue for YEARS, smart moving has already bent over backwards trying to help, screw them if they don't care enough to fix their problems.
I agree on the mission critical score. Hey, vanilla, what do you mean I can't climb an obstacle that's only 2 blocks high? Almost every modern game in the world allows climbing obstacles. Most of them will let you jump up, grab, and scale an obstacle taller than you are — 3 blocks, say. Why can't Minecraft?
You're wrong IMO about the API issue. Yes, there was an API. Yes, there was even a player model enhancer. Neither should have been necessary in the first place. It's not the responsibility of every other modder who touches the player model in any way to be compatible with Smart Moving. It's Smart Moving's responsibility to implement its modifications to the player model in a way that does not force other mods to jump through additional hoops to be compatible with Smart Moving. and de-facto have both a "Smart Moving present" and a "Smart Moving not present" version of their code. This is why Thermal Expansion implemented its own covers instead of staying multipart compatible: Building Forge Multipart compatibility into every multipartable piece in Thermal Expansion de facto meant that Thermal Expansion now had torequire Forge Multipart.
Of course, IMO in a perfect world vanilla Minecraft would adopt Smart Moving's extensions to the player model. And Gender's. But in a perfect world, vanilla Minecraft would adopt a lot of things that are now done by mods, and Mojang would reward the modders for their work. But the only case I'm aware of in which this has actually happened in vanilla Minecraft is vanilla horses. (Contrast with Forge where CoFH's Redstone Flux energy API has been almost universally adopted as the standard energy API. Though there are still holdouts of course ... I'm looking at you, IC².)
I agree on the mission critical score. Hey, vanilla, what do you mean I can't climb an obstacle that's only 2 blocks high? Almost every modern game in the world allows climbing obstacles. Most of them will let you jump up, grab, and scale an obstacle taller than you are — 3 blocks, say. Why can't Minecraft?
You're wrong IMO about the API issue. Yes, there was an API. Yes, there was even a player model enhancer. Neither should have been necessary in the first place. It's not the responsibility of every other modder who touches the player model in any way to be compatible with Smart Moving. It's Smart Moving's responsibility to implement its modifications to the player model in a way that does not force other mods to jump through additional hoops to be compatible with Smart Moving. and de-facto have both a "Smart Moving present" and a "Smart Moving not present" version of their code. This is why Thermal Expansion implemented its own covers instead of staying multipart compatible: Building Forge Multipart compatibility into every multipartable piece in Thermal Expansion de facto meant that Thermal Expansion now had torequire Forge Multipart.
Of course, IMO in a perfect world vanilla Minecraft would adopt Smart Moving's extensions to the player model. And Gender's. But in a perfect world, vanilla Minecraft would adopt a lot of things that are now done by mods, and Mojang would reward the modders for their work. But the only case I'm aware of in which this has actually happened in vanilla Minecraft is vanilla horses. (Contrast with Forge where CoFH's Redstone Flux energy API has been almost universally adopted as the standard energy API. Though there are still holdouts of course ... I'm looking at you, IC².)
you say neither should have been necessary in the first place, however if that were really the case divisor would have never seen fit to alter the minecraft player character and how it animates so drastically and smart moving would never have existed.
i cannot agree.
i also can't agree that one mod being able to identify another's presence is really that much to ask, no way in heck, not even remotely, i know for a fact versions of tinkers construct and natura confirm to each other their presence or lack thereof, there's no reason not to except being lazy was easier and sloppier.
edit: to be clear, in my opinion smart moving should have been merged with forge or vanilla years ago, it's really silly why they still haven't to be honest either.
lastly, the crawling is the big feature for me, do not want to play without.
Crawling is really an important feature, yeah, sometimes as important as climbing. No disagreement there.
There's a difference between identifying another mod's presence and enabling support for it, though, and having massively different code depending whether another mod is present or not because that mod chose to create its own player class from scratch and totally replace the vanilla player class rather than simply extending the vanilla class. Several other mod developers have called this out as a fundamental design error on Divisor's part. The fact that Smart Moving is so freaking awesomely useful does not negate that design error.
Crawling is really an important feature, yeah, sometimes as important as climbing. No disagreement there.
There's a difference between identifying another mod's presence and enabling support for it, though, and having massively different code depending whether another mod is present or not because that mod chose to create its own player class from scratch and totally replace the vanilla player class rather than simply extending the vanilla class. Several other mod developers have called this out as a fundamental design error on Divisor's part. The fact that Smart Moving is so freaking awesomely useful does not negate that design error.
it doesn't need to be "massively different" it just needs to go "oh you have smart moving, i'll disable the vanilla fallbacks and use the correct way" and that's about it, mod developers need to stop doing it wrong because it's easier is the real issue.
1. Yes, everything seems to work great! Excellent job on the port.
2. It's so nice to have Superman-style fly-where-you-look back. Gods of Chaos, I hate creative flight. Yes, creative flight is better than no flight at all, but having a refrigerator dropped on your foot is better than being stabbed in the eye with a sharpened stick, too.
3. I seem to be running into a few ...sync issues maybe? I had a sign that took me five tries to break, another that vanished when broken, and a half-dozen or so chunks of netherrack that also just vanished when broken.
4. See the console log spam issue above.
Now, that said and with massive thanks to ScienceDrummer for the update/port (I cannot emphasize that enough), there are some bugs present that are inherent in SmartMoving. For instance, if I turn around in third person view, my Thaumcraft Goggles of Revealing are suddenly on the back of my head, and my Optifine cloak is hanging down my chest like a bib. They don't move with me when I swim, fly or crawl, either, and if I go into third-person mode when I'm within sight of armor on a Bibliocraft armor stand (I haven't tested it with vanilla armor stands yet), the armor on the stand spins around like a dervish.
I want to stress these issues are not the fault of ScienceDrummer's port. They are a consequence of the underlying design decision in Smart Moving to replace, rather than extend, the vanilla player model. Many other modders have pointed to this when asked "Why isn't your mod compatible with Smart Moving?", and said, "No, you have it backwards, it's Smart Moving that is incompatible with everything else."
Disclaimer: I am not a modder myself (learning Java and modding is on my to-do-someday list) and don't know enough about the internals of Minecraft to know how difficult it is to extend the player model in a compatible way.
I do note that Divisor used to have a Player API Helper (or was it API Extender?) add-on that patched player API calls by other mods to help with these mod-interaction bugs. (My recollection is that it fixed all the ones I'm aware of except the armor-stand whirling-dervish bug and compatibility with iPixeli's Gender Mod, and the Gender Mod hasn't been updated to 1.12 yet.)
I don't know if Divisor plans on doing anything more with Smart Moving. But it would be really fantastic if some experienced modder would take on the task of looking into the core Smart Moving code and seeing whether it is possible to re-implement it in a way that does not result in incompatibility with every other mod that uses the player model in any way.
So wait, are people actually trying to recreate or port the mod over to 1.12.2?
we hope? but it looks like the only fork i see is even with the main one so i doubt he actually did anything.
Well I've tried to port it over but I don't have any coding knowledge so I didn't know how to fix a lot of the errors to even compile it back into a jar file.
If there is an effort underway to port to 1.12, it might be worth considering if it could be done by subclassing and extending the existing player class instead of replacing it. The one drawback Smart Moving always had was that it was not compatible with third-party mod-added custom armors, or with other mods that modify the player such as Gender. There was the player class replacer add-on that made it work with third-party armors such as Thaumcraft's magnificent Thaumium Fortress armor, but that had bizarre side effects on things like Bibliocraft armor stands.
Well I've opened up a GitHub issue asking if he can port the mod over to 1.12.2 since PlayerAPI 1.12.1 is out. Hopefully he responds.
From what I know about coding, the author should have gone for third party integration from the beginning.
Replacing something that other mods are going to rely on is basically saying: "My mod is only mod you need!"
In cases like Terrafirmacraft, that might be true.
Here, it is not.
Plus I also wonder why the animations can't just be done like in the vanilla game.
They have basic walking animations there, smacking stuff and now even smimming.
Even if that stuff is hardcoded in, one would simply need to make the mod a coremod to replicate it and that oughta do the trick.
Correct me.
No, not *if* I am wrong. Because I surely am. Or else the original mod author would have done the way I just described
Yes, I AM a Vampire. Nice of you to notice.
Why is that box so big? What do you mean I should stop breaking the fourth wall?
smart moving is a mission critical mod in my opinion, visual only glitches aren't even an annoyance unless i hit f5 by mistake.
also there's been a very easy to use API that other mods could and should have been plugging into to fix that issue for YEARS, smart moving has already bent over backwards trying to help, screw them if they don't care enough to fix their problems.
I agree on the mission critical score. Hey, vanilla, what do you mean I can't climb an obstacle that's only 2 blocks high? Almost every modern game in the world allows climbing obstacles. Most of them will let you jump up, grab, and scale an obstacle taller than you are — 3 blocks, say. Why can't Minecraft?
You're wrong IMO about the API issue. Yes, there was an API. Yes, there was even a player model enhancer. Neither should have been necessary in the first place. It's not the responsibility of every other modder who touches the player model in any way to be compatible with Smart Moving. It's Smart Moving's responsibility to implement its modifications to the player model in a way that does not force other mods to jump through additional hoops to be compatible with Smart Moving. and de-facto have both a "Smart Moving present" and a "Smart Moving not present" version of their code. This is why Thermal Expansion implemented its own covers instead of staying multipart compatible: Building Forge Multipart compatibility into every multipartable piece in Thermal Expansion de facto meant that Thermal Expansion now had to require Forge Multipart.
Of course, IMO in a perfect world vanilla Minecraft would adopt Smart Moving's extensions to the player model. And Gender's. But in a perfect world, vanilla Minecraft would adopt a lot of things that are now done by mods, and Mojang would reward the modders for their work. But the only case I'm aware of in which this has actually happened in vanilla Minecraft is vanilla horses. (Contrast with Forge where CoFH's Redstone Flux energy API has been almost universally adopted as the standard energy API. Though there are still holdouts of course ... I'm looking at you, IC².)
you say neither should have been necessary in the first place, however if that were really the case divisor would have never seen fit to alter the minecraft player character and how it animates so drastically and smart moving would never have existed.
i cannot agree.
i also can't agree that one mod being able to identify another's presence is really that much to ask, no way in heck, not even remotely, i know for a fact versions of tinkers construct and natura confirm to each other their presence or lack thereof, there's no reason not to except being lazy was easier and sloppier.
edit: to be clear, in my opinion smart moving should have been merged with forge or vanilla years ago, it's really silly why they still haven't to be honest either.
lastly, the crawling is the big feature for me, do not want to play without.
Crawling is really an important feature, yeah, sometimes as important as climbing. No disagreement there.
There's a difference between identifying another mod's presence and enabling support for it, though, and having massively different code depending whether another mod is present or not because that mod chose to create its own player class from scratch and totally replace the vanilla player class rather than simply extending the vanilla class. Several other mod developers have called this out as a fundamental design error on Divisor's part. The fact that Smart Moving is so freaking awesomely useful does not negate that design error.
it doesn't need to be "massively different" it just needs to go "oh you have smart moving, i'll disable the vanilla fallbacks and use the correct way" and that's about it, mod developers need to stop doing it wrong because it's easier is the real issue.
Hello Divisor can you please update the mod to 1.12.2 please. I will understand if you can't do it.
So tell me if you can or can't.
Oh sh*t guys. https://github.com/Tommsy64/SmartMoving/releases/tag/1.12.2-16.4-RC3
awesome, i'm gonna fire up a new instance and drop them all in and see what explodes.
[edit] gets in game fine, nothing appears to be broken at first glance, climbing and crawling work, nothing else tested [/edit]
My hand is missing though, which sucks. :/
I don't know how to use Github.
Does this mean the mod is now working?
Yes, I AM a Vampire. Nice of you to notice.
Why is that box so big? What do you mean I should stop breaking the fourth wall?
it means there's release candidate 3 download versions of it.
as i posted before, i didn't test much at all but it appeared functional from the very limited testing i've done.
Firing it up...
This RC is constantly flooding my console with:
OK, having tested a bit:
1. Yes, everything seems to work great! Excellent job on the port.
2. It's so nice to have Superman-style fly-where-you-look back. Gods of Chaos, I hate creative flight. Yes, creative flight is better than no flight at all, but having a refrigerator dropped on your foot is better than being stabbed in the eye with a sharpened stick, too.
3. I seem to be running into a few ...sync issues maybe? I had a sign that took me five tries to break, another that vanished when broken, and a half-dozen or so chunks of netherrack that also just vanished when broken.
4. See the console log spam issue above.
Now, that said and with massive thanks to ScienceDrummer for the update/port (I cannot emphasize that enough), there are some bugs present that are inherent in SmartMoving. For instance, if I turn around in third person view, my Thaumcraft Goggles of Revealing are suddenly on the back of my head, and my Optifine cloak is hanging down my chest like a bib. They don't move with me when I swim, fly or crawl, either, and if I go into third-person mode when I'm within sight of armor on a Bibliocraft armor stand (I haven't tested it with vanilla armor stands yet), the armor on the stand spins around like a dervish.
I want to stress these issues are not the fault of ScienceDrummer's port. They are a consequence of the underlying design decision in Smart Moving to replace, rather than extend, the vanilla player model. Many other modders have pointed to this when asked "Why isn't your mod compatible with Smart Moving?", and said, "No, you have it backwards, it's Smart Moving that is incompatible with everything else."
Disclaimer: I am not a modder myself (learning Java and modding is on my to-do-someday list) and don't know enough about the internals of Minecraft to know how difficult it is to extend the player model in a compatible way.
I do note that Divisor used to have a Player API Helper (or was it API Extender?) add-on that patched player API calls by other mods to help with these mod-interaction bugs. (My recollection is that it fixed all the ones I'm aware of except the armor-stand whirling-dervish bug and compatibility with iPixeli's Gender Mod, and the Gender Mod hasn't been updated to 1.12 yet.)
I don't know if Divisor plans on doing anything more with Smart Moving. But it would be really fantastic if some experienced modder would take on the task of looking into the core Smart Moving code and seeing whether it is possible to re-implement it in a way that does not result in incompatibility with every other mod that uses the player model in any way.