Minecraft Forums

Quote from Gogsi123

I'm also trying to implement cooldown on the mana item. Item.onUpdate() is "Called each tick as long the item is on a player inventory" . From what i know 20 game ticks are 1 second but setting the cooldown to 100 secs and decreasing it every onUpdate takes 2.4 secs accoarding to my stopwatch. What am I doing wrong?

Edit: So I realised that onUpdate is being called 40 times per second but I don't know why.

private int delayTimer;

public int setDelayTimer(int timer) {
	   if(this.delayTimer != timer) {
		    this.delayTimer = timer;
		    this.sync;
	   }
	 
	  return this.delayTimer
}

public int getDelayTimer() {
	  return this.delayTimer;
}

if(!world.isRemote) {
	  EntityPlayer ent = (EntityPlayer)event.entityLiving;
      ExtendedPlayer props = ExtendedPlayer.get(ent);
      int mana = props.getCurrentMana();
      int maxmana = props.getMaxMana();
	  if(mana < maxmana) {
		   int timer = props.getDelayTimer();
		   timer++
		   if(timer >= 200) { //10 Seconds
			   props.comsumeMana(the amount you want to comsume);
			   //And whatever else, like spawn an entity or something.
		   }

		  props.setDelayTimer(timer);

		  if(timer == 200) { //Or how ever many ticks you set up above.
			  props.setDelayTimer(0);
		  }
	  }else {
		  return; //You have to have an else, this just returns nothing.
	  }
 }

Quote from coolAlias

It is called on both the client and the server side, but each of those counts separately so shouldn't affect the overall time. You can run the code only on the server by nesting your code in an if world is not remote statement "if (!world.isRemote)", but without seeing your entire Item class it's hard to say why there would be such a huge discrepancy in the time.

If you are using a local integer field in your Item class as the timer, don't. Either store the timer in NBT (preferred, as it keeps the timer in the Item, with one timer per unique stack), or try something like HappyKiller101 suggested (not the best in this type of situation - what if you had two items that needed timers?).


Honestly it's been a long time since I've messed with tick handlers, but ideally it will run on both sides; if you have to choose, then go with Server side, but you want the Player tick (which is called on both sides), not server or client tick.

How do you get the custom inventory? The same way you get any object in Java, by either making it public or using a getter. If your problem is that you can't seem to find an EntityPlayer variable in the TickHandler, I believe that the method parameter tickData[0] is an EntityPlayer. To check, simply "println("Is tickData[0] a player? " + (tickData[0] instanceof EntityPlayer))", run the game, and you'll find out. If the player isn't at tickData[0], then it's tickData[1]. Again, you need to look and check for yourself, as I'm just going off my vague memory here.

EDIT: Saw your code for adding the potion effects, looks about right. You could have it check less frequently, even every other tick rather than every single tick (I typically check every 4, 8, 16, or some other power of 2 so I can use bitwise operators >> instead of modulus %), and give your potion effects a sufficient duration to cover that period of time.

For flying, please search "flying armor" or some such in the Modification Development section - there are TONS of threads about flying.

For custom slot background, you need to create a custom Slot class and override whichever slot background method there is - it's what the Armor slots use to get the empty armor icon in the background.

Quote from coolAlias

Ah, you need other players to see the item for rendering purposes - you need to send a packet to all nearby players, then, just like before. You can read about converting to the Netty packet system in the tutorial section about updating to 1.7.2.

Quote from coolAlias

As long as the data is correct on the server, you can get the sum of the coins from the server. You should never synchronize between players, only between player and server. By default, however, you will only have access to the players that are currently online when summing the total amount of gold in the game; if you want access to the total gold even if a player is offline, you will need to store the amount of gold each player has on the server, rather than as part of the player's data file.