Minecraft Forums

Well my Crafting method works, but my smelting and pickup dont work ._.

//Achievement
FMLCommonHandler.instance().bus().register(new AchievementHandler());

http://pastebin.com/X2wA6ipf

Dragonisser

Quote from EliteCreature

So I have been following your Extended Entity Properties Tutorial to the letter. (I'm in 1.7.2)I have currently set everything up as requested, and I am trying to get it to work correctly WITHOUT using datawatchers.But from the way your updated tutorial is working, I have to use datawatchers for currentMana to work, correct?

edit: and by work, I am referring to the guiManaBar

edit: are all 26 free values of DataWatcher shared by everyone, or is it 26 per mod?

DataWatcher indices are shared by ALL mods, so it's 32 total for everyone, less the ones used by vanilla. You don't have to use DataWatcher at all, it's just convenient. DW uses packets to synchronize anyway, so no reason not to use packets yourself.

Quote from Dragonisser

Well my Crafting method works, but my smelting and pickup dont work ._.

//Achievement
FMLCommonHandler.instance().bus().register(new AchievementHandler());

http://pastebin.com/X2wA6ipf

Dragonisser

Whoa... NEVER compare ItemStacks using ==, that compares identity (i.e. memory location), so when you do this:

@SubscribeEvent
public void onCrafting(ItemCraftedEvent event) {
ItemStack CobaltBlock = new ItemStack(CMStuff.cobaltblock);

// I highly doubt this if statement ever evaluates to true:
if (event.crafting == CobaltBlock)

You've just created a NEW memory location with an ItemStack, and are comparing it to the memory location of a different ItemStack in event.crafting/smelting/whatever.

You can use Block.getItemFromBlock(Block) to get an Item instance of a Block:

if (event.crafting.getItem() == Block.getItemFromBlock(CMStuff.cobaltblock)) {

Keep in mind this is also comparing memory locations, but it is safe because Items and Blocks are static, meaning there is only a single instance of it (one memory location) across the entire mod, but ItemStacks each have unique instances.

Oddly enough, out of all your code there, only the ItemSmeltedEvent looks like it should actually 100% work, but you say it doesn't. Try putting a println in there to see if it is called when you smelt an item , and print out what item was smelted. It may be that you are checking for the wrong item.

Quote from coolAlias

-snip-

Do you know why the PickupEvent dont work?

Quote from Dragonisser

Do you know why the PickupEvent dont work?

Yes, for the exact same reason I just posted above.

Quote from coolAlias

Yes, for the exact same reason I just posted above.

if (event.pickedUp.getEntityItem().getItem() == Item.getItemFromBlock(CMStuff.cobaltore))
{
event.player.addStat(mod_cobalt.cobaltachiev1, 1);
}

doesn't work either

Quote from Dragonisser

if (event.pickedUp.getEntityItem().getItem() == Item.getItemFromBlock(CMStuff.cobaltore))
{
event.player.addStat(mod_cobalt.cobaltachiev1, 1);
}

doesn't work either

No? I just tried it and it worked perfectly well:

// double-check your import:
import cpw.mods.fml.common.gameevent.PlayerEvent.ItemPickupEvent;

@SubscribeEvent
public void onPickup(ItemPickupEvent event) {
   	 if (event.pickedUp.getEntityItem().getItem() == ZSSItems.bomb) {
            System.out.println("Picked up a bomb!");
        } else if (event.pickedUp.getEntityItem().getItem() == Item.getItemFromBlock(ZSSBlocks.chestLocked)) {
            System.out.println("Picked up a locked chest!");
        }
}

Both printed to the console when I picked up the appropriate item / block.

Quote from coolAlias

No? I just tried it and it worked perfectly well:

// double-check your import:
import cpw.mods.fml.common.gameevent.PlayerEvent.ItemPickupEvent;

@SubscribeEvent
public void onPickup(ItemPickupEvent event) {
	 if (event.pickedUp.getEntityItem().getItem() == ZSSItems.bomb) {
System.out.println("Picked up a bomb!");
} else if (event.pickedUp.getEntityItem().getItem() == Item.getItemFromBlock(ZSSBlocks.chestLocked)) {
System.out.println("Picked up a locked chest!");
}
}

Both printed to the console when I picked up the appropriate item / block.

Works now ^^ thx

Quote from Gyullo

I read the whole TH, but i cant find (or maybe im blind) the method to save ExtendedPlayer info through logout/login or server down/up.

I wnat my current mana to be save even after you log out, so when you log in, you should have the same amount of mana, you had when you left.

Can you please help me with this?

If you followed the tutorial exactly, that should already be happening. The current mana is saved to NBT whenever the game saves, and loads whenever the game loads; make sure your custom data is being synchronized on the client when you load your game. I do this when the properties load from the proxy, which I call from EntityJoinWorldEvent.

Quote from zacharyjaiden74

how would you using your tutorial as an example would you gain mana upon breaking a custom block (if at all possible)

Replenish some mana when the block breaks If it's a custom block, you can override Block#onBlockDestroyedByPlayer and do it from there, otherwise you will need to use the BreakEvent located in net.minecraftforge.event.world.BlockEvent.

Quote from Gyullo

Now its working, it was a mistake I made in the proxy part.
I really appreciate your guides

Great xD

Quote from zacharyjaiden74

Could you provide an example ? I've already tried that and it does in fact work increasing my unit total (in your example mana but crashes at the same Time I'm trying to figure out a way that won't crash

Edit it's not the code itself cause I can do it through forge events (holding shift increases mana)

So it's the way I'm ring to add it to a block break method

The way I'm implementing it requires the perimeter "player" which block break event doesn't have

Did you not read my post? I did not say use Block#breakBlock method. I said you can use the Forge EVENT for BreakBlock, OR you can use the Block#onBlockDestroyedByPlayer method from within your custom Block class.

Quote from zacharyjaiden74

Sorry miscommunication I didn't mean method as in actual coding term of method I meant method as in "way of doing it"

I'm obviously doing something wrong :/ I'll recheck the code

If you post your code I can help you figure out what's wrong; it's likely just a null pointer or something that you forgot to check for.

You said you had a custom Block, right? In the Block class, there is this method:

/**
 * Called when the block is attempted to be harvested
 */
public void onBlockHarvested(World world, int x, int y, int z, int meta, EntityPlayer player) {}

Turns out the onBlockDestroyedByPlayer didn't actually have an EntityPlayer argument, but onBlockHarvested does.

If you need it to work for ANY block, then like I already mentioned, you need to subscribe to the net.minecraftforge.event.world.BlockEvent.BreakEvent event.