Minecraft Forums

I know alot of people are going to say copy it from the ItemBucket class. Well, I did and it doesn't work. The bucket turns to an iron bucket every time you pick up or place a liquid. If anyone has any ideas, the help would be much appreciated. Below is my code.

package x17guard.custommod.items;

import x17guard.aluminumexpansion.Base;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBucket;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumMovingObjectType;
import net.minecraft.util.MovingObjectPosition;
import net.minecraft.world.World;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.Event;
import net.minecraftforge.event.entity.player.FillBucketEvent;

public class CustomBucket extends Item
{
/** field for checking if the bucket has been filled. */
private int isFull;

public AluminumBucket(int par1, int par2)
{
super(par1);
this.maxStackSize = 1;
this.isFull = par2;
this.setCreativeTab(CreativeTabs.tabMisc);
}

/**
* Called whenever this item is equipped and the right mouse button is pressed. Args: itemStack, world, entityPlayer
*/
public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
{
boolean flag = this.isFull == 0;
MovingObjectPosition movingobjectposition = this.getMovingObjectPositionFromPlayer(par2World, par3EntityPlayer, flag);

if (movingobjectposition == null)
{
return par1ItemStack;
}
else
{
FillBucketEvent event = new FillBucketEvent(par3EntityPlayer, par1ItemStack, par2World, movingobjectposition);
if (MinecraftForge.EVENT_BUS.post(event))
{
return par1ItemStack;
}

if (event.getResult() == Event.Result.ALLOW)
{
if (par3EntityPlayer.capabilities.isCreativeMode)
{
return par1ItemStack;
}

if (--par1ItemStack.stackSize <= 0)
{
return event.result;
}

if (!par3EntityPlayer.inventory.addItemStackToInventory(event.result))
{
par3EntityPlayer.dropPlayerItem(event.result);
}

return par1ItemStack;
}

if (movingobjectposition.typeOfHit == EnumMovingObjectType.TILE)
{
int i = movingobjectposition.blockX;
int j = movingobjectposition.blockY;
int k = movingobjectposition.blockZ;

if (!par2World.canMineBlock(par3EntityPlayer, i, j, k))
{
return par1ItemStack;
}

if (this.isFull == 0)
{
if (!par3EntityPlayer.canPlayerEdit(i, j, k, movingobjectposition.sideHit, par1ItemStack))
{
return par1ItemStack;
}

if (par2World.getBlockMaterial(i, j, k) == Material.water && par2World.getBlockMetadata(i, j, k) == 0)
{
par2World.setBlockToAir(i, j, k);

if (par3EntityPlayer.capabilities.isCreativeMode)
{
return par1ItemStack;
}

if (--par1ItemStack.stackSize <= 0)
{
return new ItemStack(Base.AbucketWater);
}

if (!par3EntityPlayer.inventory.addItemStackToInventory(new ItemStack(Base.AbucketWater)))
{
par3EntityPlayer.dropPlayerItem(new ItemStack(Base.AbucketWater.itemID, 1, 0));
}

return par1ItemStack;
}

if (par2World.getBlockMaterial(i, j, k) == Material.lava && par2World.getBlockMetadata(i, j, k) == 0)
{
par2World.setBlockToAir(i, j, k);

if (par3EntityPlayer.capabilities.isCreativeMode)
{
return par1ItemStack;
}

if (--par1ItemStack.stackSize <= 0)
{
return new ItemStack(Item.CustomBucketLava);
}

if (!par3EntityPlayer.inventory.addItemStackToInventory(new ItemStack(Item.CustomBucketLava)))
{
par3EntityPlayer.dropPlayerItem(new ItemStack(Item.CustomBucketLava.itemID, 1, 0));
}

return par1ItemStack;
}
}
else
{
if (this.isFull < 0)
{
return new ItemStack(Base.CustomBucket);
}

if (movingobjectposition.sideHit == 0)
{
--j;
}

if (movingobjectposition.sideHit == 1)
{
++j;
}

if (movingobjectposition.sideHit == 2)
{
--k;
}

if (movingobjectposition.sideHit == 3)
{
++k;
}

if (movingobjectposition.sideHit == 4)
{
--i;
}

if (movingobjectposition.sideHit == 5)
{
++i;
}

if (!par3EntityPlayer.canPlayerEdit(i, j, k, movingobjectposition.sideHit, par1ItemStack))
{
return par1ItemStack;
}

if (this.tryPlaceContainedLiquid(par2World, i, j, k) && !par3EntityPlayer.capabilities.isCreativeMode)
{
return new ItemStack(Base.CustomBucket);
}
}
}

return par1ItemStack;
}
}

/**
* Attempts to place the liquid contained inside the bucket.
*/
public boolean tryPlaceContainedLiquid(World par1World, int par2, int par3, int par4)
{
if (this.isFull <= 0)
{
return false;
}
else
{
Material material = par1World.getBlockMaterial(par2, par3, par4);
boolean flag = !material.isSolid();

if (!par1World.isAirBlock(par2, par3, par4) && !flag)
{
return false;
}
else
{
if (par1World.provider.isHellWorld && this.isFull == Block.waterMoving.blockID)
{
par1World.playSoundEffect((double)((float)par2 + 0.5F), (double)((float)par3 + 0.5F), (double)((float)par4 + 0.5F), "random.fizz", 0.5F, 2.6F + (par1World.rand.nextFloat() - par1World.rand.nextFloat()) * 0.8F);

for (int l = 0; l < 8; ++l)
{
par1World.spawnParticle("largesmoke", (double)par2 + Math.random(), (double)par3 + Math.random(), (double)par4 + Math.random(), 0.0D, 0.0D, 0.0D);
}
}
else
{
if (!par1World.isRemote && flag && !material.isLiquid())
{
par1World.destroyBlock(par2, par3, par4, true);
}

par1World.setBlock(par2, par3, par4, this.isFull, 0, 3);
}

return true;
}
}
}
}

Here is all relevant code. Every time my bucket picks up something, it turns into an iron bucket holding that liquid. Every time I empty my buckets they turn to empty iron buckets. Any help would be very appreciated.

I'm pretty sure the bucket thing is coded elsewhere, copying the ItemBucket won't help you :/

Where is this bucket class then?