Minecraft Forums

CubeX2, can you do if block has canFaceTop attribute to false texture for facing block will be looks like pumpkin in inventory? My English is bad and i can't say more. If you understand me - please say. If now - i try to tell more good. =\

Quote from Black_Eye

ALL RIGHT! CS2 is working fine now, new update is cool, thanks dude

Back to the common problems of us CS users the coding^^

Still trying to implement an "Auto-Repair" Sword...
It's basicly working, but I'm not able to destroy any block with it (not even a snow layer lol)
If I leftclick a grass block it will just shortly show the destroying-animation, like 0,2-3 seconds...
Then the grass block is showen as never touched before and it will start again^^

sword.js

id = config.getItemId("mySwordId");
name = "mySword";
displayName[0] = "My Sword";
addToCreative[0] = true;
creativeTab = "combat";
damage[0] = 10;
full3d = true;
effectiveBlocks = "30";
harvestBlocks = "30";
efficiency[0] = 6.0;
maxDamage = 200;
maxUsingDuration[0] = 72000;
usingAction[0] = "block";
onHitEntity[0] = "itemstack.damageItem(1);";
onRightClick[0] = "player.setItemInUse();";
onBlockDestroyed[0] = "itemstack.damageItem(2);";
onUpdate[0] = "mod.loadScript('auto-repair.js');";

textureFile[0] = "sword.png";

mod.js

config.addItemIdProperty("mySwordId", 16000);
mod.addItem("mySword.js", "normal");

auto-repair.js

if(itemstack.getIntData("repairCounter") >= 100) {
//triggers ever 5 seconds (100/20=5)
itemstack.setIntData("repairCounter", 0); //resets counter regardless of damage
if(itemstack.getDamage() > 0) {
//Only triggers if item is damaged and previous if statement succeeded
itemstack.setDamage(itemstack.getDamage() - 1);
}
} else {
itemstack.setIntData("repairCounter", itemstack.getIntData("repairCounter") + 1);
}

Thanks for everything appreciate the help of all here!

Just to be clear, does the sword not break blocks even if it is undamaged (damage showing as 0)? If it only has problems while it is damaged, then you may need to add a line to the onBlockDestroyed event so that "repairCounter" is set to -1100 so that there is a 1 minute cooldown [ (1100+100)/20=60 seconds] between when you break a block and the item starts self-repairing. Unfortunately, once you stop mining for 1 minute, the tool would be unusable until fully repaired or a weak block is broken.

Alternatively, you could make the auto-repair be slower so that a block can be broken before auto-repair interrupts breaking the block. Unfortunately, this method still allows the auto-repair to randomly interrupt you.

If the problem was only present when the tool is damaged, then my overall suggestion would be to combine both the cooldown after last block broken and a longer auto-repair cycle for the reasons listed above.

If the problem is that you can't break any blocks even while the tool is undamaged, then I will have to do some testing. It is possible that setting the int data could be causing the tool to stop mining for an instant. If this is the case, it may be difficult to find a working solution. =\

So now that Thermal Expansion support is in, what would be the proper language to create an Induction Smelter recipe? I'd assume mod.addISmelterRecipe( ); but not a clue what order the values should go into it

Quote from Black_Eye

I made the auto-repair slower, it still won't let me harvest any block...

maybe combine it with right click the item?

when using a sword it's not that important with harvesting, but blocking on the right click... so it's fine the way it is

but I want to add several items like shovels etc.

when adding a pickaxe, am I able to set the repairing to start if i rightclick the item?
So the person using the pickaxe can mine... til the damage counter is to 50 or lower, right click and wait till the item is full again to start mining again?

If yes.... please enlighten my coding-skills xD

some suggesion
Why not use new Date to get the current time\
And use onBlockDestroyed to record the time¤t damage
And when next time you break block with it , get the saved time & damage
And compare to current time ,
ex : if it is 5 minute later after you use the item last time ,repair the item by 1
if 10 ; by 2
By the Date object in javascript ; you can make it self-repair even you are not online.

edited : it seems the scripts cancel the progress you are destroy the block when it is excuted,so maybe onBlockDestroyed will also not work

Quote from mmis1000

some suggesion
Why not use new Date to get the current time\
And use onBlockDestroyed to record the time¤t damage
And when next time you break block with it , get the saved time & damage
And compare to current time ,
ex : if it is 5 minute later after you use the item last time ,repair the item by 1
if 10 ; by 2
By the Date object in javascript ; you can make it self-repair even you are not online.

edited : it seems the scripts cancel the progress you are destroy the block when it is excuted,so maybe onBlockDestroyed will also not work

Using a time object instead of a counter is a great idea! I haven't used the time object at all so will need to experiment a bit with it.

I though onBlockDestroyed was supposed to activate after the block was destroyed... that sucks if it resets progress even with onBlockDestroyed. >.<

So far it is sounding like automatically repairing tools won't work very well until tickrate is added for items. =(

Edit: Thought of a nice way to get around the problem. If you add a condition that the onUpdate script only runs while the tool isn't the active item, then there is no problem with it updating while the player is mining. Refer to the code at the end of this post to see what I mean.

Quote from Black_Eye

I made the auto-repair slower, it still won't let me harvest any block...

maybe combine it with right click the item?

when using a sword it's not that important with harvesting, but blocking on the right click... so it's fine the way it is

but I want to add several items like shovels etc.

when adding a pickaxe, am I able to set the repairing to start if i rightclick the item?
So the person using the pickaxe can mine... til the damage counter is to 50 or lower, right click and wait till the item is full again to start mining again?

If yes.... please enlighten my coding-skills xD

It would be possible to use the onRightClick trigger to set a variable that would start the auto-repair process. You would need to add another condition to your onUpdate trigger to either check if the tool is greater than or equal to 0 if you set the value to -1 when not in use. Alternatively, you could add a bool value that gets set to true by onRightClick and set to false by onUpdate being done repairing.

I think I have come up with an easier and less restrictive method to the auto-repair setup though. Just make it so the tool only auto-repairs while the tool is not the active item. In other words, when the tool is in the player's inventory but not in his hand. Here is all you would need to change:

onUpdate[0] = "if(isCurrentItem == false){mod.loadScript('auto-repair.js');}";

Hopefully, that fixs the problem. Enjoy!

http://minecraftmodcustomstuff.wikia.com/wiki/Bucket - The page to the bucket. Go to bottom and click expand.

This is the code for the old bucket item in CS1. What parts will I need to change to make it function in CS2?

Quote from michael1973

var myLiquids = new Array(8,9,10,11,136,137);
switch(side)
{
case 0:
position.y--;
break;
case 1:
position.y++;
break;
case 2:
position.z--;
break;
case 3:
position.z++;
break;
case 4:
position.x--;
break;
case 5:
position.x++;
break;
default:
player.sendMessage('An unknown side has been clicked.');
break;
}
for(var liquidlist = 0; liquidlist < myLiquids.length; liquidlist++)
{
if(world.getBlockMetadata(position) == 0 && world.getBlockId(position) == myLiquids[liquidlist])
{
	 switch(world.getBlockId(origin))
	 {
		 case 8:
		 case 9:
			 world.setBlockId(position, 0);
			 player.removeFromSlot(player.getCurrentSlot(), 1);
			 player.add(702, 1, 0);
			 break;
		 case 10:
		 case 11:
			 world.setBlockId(position, 0);
			 player.removeFromSlot(player.getCurrentSlot(), 1);
			 player.add(703, 1, 0);
			 break;
		 case 136:
		 case 137:
			 world.setBlockId(position, 0);
			 world.createExplosion(position, 8);
			 break;
	 }
}
}

http://minecraftmodc...com/wiki/Bucket - The page to the bucket. Go to bottom and click expand.

This is the code for the old bucket item in CS1. What parts will I need to change to make it function in CS2?

Why are you trying to use the old bucket workaround for CS2? The bucket item type does a much better and less glitchy job of making custom liquids work in buckets. Are you trying to make a bottle of the liquid or something?

Regardless, since someone seems to have partially edited it to CS2 already the only line that I know needs changing is the following line needs to be changed from origin to position:

switch(world.getBlockId(origin)) //before

switch(world.getBlockId(position)) //after

I will look again after I have had some sleep to see if I am missing anything else that needs changed, but it looks like that is everything.

Quote from Flamarow

Why are you trying to use the old bucket workaround for CS2? The bucket item type does a much better and less glitchy job of making custom liquids work in buckets. Are you trying to make a bottle of the liquid or something?

Regardless, since someone seems to have partially edited it to CS2 already the only line that I know needs changing is the following line needs to be changed from origin to position:

switch(world.getBlockId(origin)) //before

switch(world.getBlockId(position)) //after

I will look again after I have had some sleep to see if I am missing anything else that needs changed, but it looks like that is everything.

I want to make an empty bucket, e.g. Wooden Bucket, Golden Bucket, etc. that can pick up liquids and place them and give me back the new bucket

Quote from Vexatos

Mhm... How to set harvestBlocks to something shown in the config?

//harvestBlocks = config.getBlockId("InfusedObsidianID") + ":1",config.getBlockId("InfusedObsidianID") + ":2",config.getBlockId("ObsiFurnaceID") + ":0",config.getBlockId("ObsiFurnaceID") + ":1";
//effectiveBlocks = config.getBlockId("InfusedObsidianID") + ":1",config.getBlockId("InfusedObsidianID") + ":2",config.getBlockId("ObsiFurnaceID") + ":0",config.getBlockId("ObsiFurnaceID") + ":1";

That does not work... Is it possible, and if it is, how?

You need your commas to be inside of the quotes just like in the example from the documentation, shown below:

harvestBlocks = "1,14,15,16";

You have also forgot a few plus signs between your text and your next config call. Here is the fixed version for reference.

harvestBlocks = config.getBlockId("InfusedObsidianID") + ":1," + config.getBlockId("InfusedObsidianID") + ":2," + config.getBlockId("ObsiFurnaceID") + ":0," + config.getBlockId("ObsiFurnaceID") + ":1";

effectiveBlocks = config.getBlockId("InfusedObsidianID") + ":1," + config.getBlockId("InfusedObsidianID") + ":2," + config.getBlockId("ObsiFurnaceID") + ":0," + config.getBlockId("ObsiFurnaceID") + ":1";

Hope that works for you. If not, try using variables instead.

Bug:

Command "onWalkingPlayer[0] = "world.createExplosion(position, 5.0, false);";" does not work. Block does not react to the player. onWalkingLiving - not work too, for player and for mobs


When used onWalking [0] = "world.createExplosion (position, 5.0, false);"; to create mines everything works, but after the explosion blocks disappear, but their ghosts remain. The player got stuck in the air and explosions continue.

Quote from Vexatos

Variables don't work either:

var modObsiID2 = config.getBlockId("InfusedObsidianID");
var furnObsiID2 = config.getBlockId("ObsiFurnaceID");
harvestBlocks = modObsiID2 + ":1," + modObsiID2 + ":2," + furnObsiID2 + ":0," + furnObsiID2 + ":1,";
effectiveBlocks = modObsiID2 + ":1," + modObsiID2 + ":2," + furnObsiID2 + ":0," + furnObsiID2 + ":1,";

Or am I just stupid?

EDIT:
Setting up a custom toolClass worked!
EDIT 2:
Does not work for the ObsiFurnace... Why?

The very last item should not have a comma at the end.

Quote from Vexatos

Still doesn't work...

Hmm... I don't know what the problem is then, there should have been a crash if it couldn't use the config scripting functions. =\

As for the furnace, make sure you set the toolClass for both damage value 0 and 1.

toolClass[0] = "pickaxe";
harvestLevel[0] = 2;

toolClass[1] = "pickaxe";
harvestLevel[1] = 2;

Hope that works for you. I will try to figure out what the exact problem is with harvestBlocks and effectiveBlocks later. =\