Jump to content

  • Curse Sites
Become a Premium Member! Help
Latest News Article

Water Spring Propagation Fix

1.3.2 1.3.1 1.2.5 ssp smp tweaks

  • Please log in to reply
38 replies to this topic

#1

PsionOmikron
  • Minecraft: PsionOmikron

Posted 30 April 2012 - 07:06 AM

This mod corrects the spread of water source blocks (springs) so that the surface of water deeper than one block will fill in correctly.


Background

Minecraft will create a water source block (spring) at an empty location if that empty location is adjacent (horizontally) to two or more water springs and the material below is "solid".

Minecraft currently has a bug that prevents a water spring from being created if the empty location is directly above another water spring. In the picture below, the empty location between the water springs will not become a water spring itself.

Posted Image

This leads to annoying currents and painfully tedious ways of fixing them. This mod corrects this problem, so that, in the picture above, the empty location between the water springs will itself become a water spring.




Download Water Propagation Fix for Minecraft 1.3.2 (Client and Server)


Client Installation
Spoiler:


Server Installation
Spoiler:


Older Releases


Details for developers and those who care
Spoiler:


Register or log in to remove.

#2

minecraftfanaticism7525
  • Location: Computer
  • Minecraft: koh1998

Posted 30 April 2012 - 10:46 AM

Fuk yeah! But why doesnt Jeb_ put in game vanilla?

#3

jdwarfer
    jdwarfer

    Redstone Miner

  • Members
  • 531 posts

Posted 30 April 2012 - 11:30 AM

Nice one, thanks !

#4

bell345
    bell345

    Tree Puncher

  • Members
  • 31 posts
  • Location: On the cloud
  • Minecraft: room5thom
  • Xbox:IceTree42

Posted 30 April 2012 - 12:33 PM

Brilliant mod!
I seriously hope that jeb_ puts this into 1.3!
I'm surprised that a 2-year old problem has been fixed only 5 hours ago...
Posted Image

#5

SkylarScaling

Posted 01 May 2012 - 05:17 AM

Works perfectly. Filled a 3x3x3 and a 4x4x2 pool in a snap. This NEEDS to get into vanilla Minecraft.

#6

zephraph
    zephraph

    Tree Puncher

  • Members
  • 37 posts

Posted 01 May 2012 - 05:34 AM

Nice catch!

#7

Nilstar
    Nilstar

    Tree Puncher

  • Members
  • 18 posts
  • Minecraft: Nilstar

Posted 29 May 2012 - 08:01 PM

-i  thank Wheezy for sending me here
-i thank you making the mod

#8

blakethegrea

Posted 29 May 2012 - 08:28 PM

its actually pretty obvious why it wasnt put in the game. What if you put to large walls of waters at the ends of the map, well then hope you like having a flooded map. but nice mod

#9

JonathanTheBlack

Posted 12 August 2012 - 12:19 PM

Hrm... how does this affect waterfalls down the side of a rock cliff? Does it turn all the water blocks of the waterfall into source blocks?

#10

LOLerul2
    LOLerul2

    Zombie Killer

  • Members
  • 198 posts

Posted 12 August 2012 - 12:48 PM

View Postblakethegrea, on 29 May 2012 - 08:28 PM, said:

its actually pretty obvious why it wasnt put in the game. What if you put to large walls of waters at the ends of the map, well then hope you like having a flooded map. but nice mod

He's more right than ever.
Enjoy your flooded map Posted Image


BTW, ends of the map? Do they even exist? LOL I didn't knew that minecraft has limited map generation.

#11

TechGuy543
  • Location: QLD, Australia

Posted 12 August 2012 - 12:54 PM

Great mod. As has been said, this really does need to be in Vanilla Minecraft.

“Computers are incredibly fast, accurate and stupid; humans are incredibly slow, inaccurate and brilliant;
together they are powerful beyond imagination."


#12

HerrGohlem

Posted 14 August 2012 - 11:36 AM

Your Mod is Great

Will you Port this Mod to bukkit ?

We use Movecraft on our Server and the submarines destroy the Ocean your Mod fix this

#13

PsionOmikron
  • Minecraft: PsionOmikron

Posted 17 August 2012 - 03:11 AM

View Postblakethegrea, on 29 May 2012 - 08:28 PM, said:

its actually pretty obvious why it wasnt put in the game. What if you put to large walls of waters at the ends of the map, well then hope you like having a flooded map. but nice mod

In the details for developers section I lay out why this is a bug. It's clearly not intentional because all of the logic is there, it's just got a typo.

#14

PsionOmikron
  • Minecraft: PsionOmikron

Posted 17 August 2012 - 03:16 AM

View PostJonathanTheBlack, on 12 August 2012 - 12:19 PM, said:

Hrm... how does this affect waterfalls down the side of a rock cliff? Does it turn all the water blocks of the waterfall into source blocks?

It does not. For an air gap/flowing water section to become a source block, it has to be horizontally touching two source blocks and have another source block immediately below it. A waterfall will not meet this condition.

#15

oOGeneral_RyanOo
  • Location: Teh inturwebz
  • Minecraft: oOGeneral_RyanOo
  • Xbox:General Ryan

Posted 17 August 2012 - 03:47 AM

View PostLOLerul2, on 12 August 2012 - 12:48 PM, said:

He's more right than ever.
Enjoy your flooded map Posted Image


BTW, ends of the map? Do they even exist? LOL I didn't knew that minecraft has limited map generation.
Look up "farlands". Minecraft used to generate strangely at a certain point and it became incredibally laggy due to glitchey sand and gravel. In BETA 1.8, the farlands where removed and replaced with a giant ocean, making minecraft a giant island/chain of islands.
Posted ImageGimme an internet, plz?

#16

Keybounce

Posted 17 August 2012 - 05:45 PM

My ocean thanks you!
My channel with Mystcraft, and general Minecraft Let's Plays: http://www.youtube.com/user/Keybounce
** NEW: FtB "Magic Farm", performance testing and java flags.
My main world: http://www.minecraft...ts-play-series/
"Wait, an update?! Geez, I didn't know we skipped Easter and went straight to Christmas."

#17

Keybounce

Posted 24 August 2012 - 12:21 AM

I am getting a strange error in 1.2.5. I don't know who/which mod is responsible, but I'm using yours.

The error first occurred the last time I played, trying to go into the nether.
It now happens at startup.

Spoiler:

The server was created by the following:
Spoiler:

Can you help me locate this error?

EDIT: Found, Lights Out and Forge conflict.
My channel with Mystcraft, and general Minecraft Let's Plays: http://www.youtube.com/user/Keybounce
** NEW: FtB "Magic Farm", performance testing and java flags.
My main world: http://www.minecraft...ts-play-series/
"Wait, an update?! Geez, I didn't know we skipped Easter and went straight to Christmas."

#18

Neon_ColorsFTW22
  • Minecraft: NeonColorsAero

Posted 24 August 2012 - 02:35 AM

Well now I don't need to waster a lot of time on making a large pool now!

Thanks! :D

Posted Image


#19

specktre
    specktre

    Zombie Killer

  • Members
  • 181 posts
  • Location: swamp biome
  • Minecraft: specklespack
  • Xbox:Wrenhaven

Posted 24 August 2012 - 03:08 AM

Oooh this is fantastic

Posted Image


#20

EdGruberman
  • Location: Tucson, AZ
  • Minecraft: EdGruberman

Posted 27 September 2012 - 05:51 AM

If anyone is interested on a commit you can pull for a custom CraftBukkit build you can get it here:
https://github.com/E...12585c54c8da071

Of note, these fixes do not address the underwater currents that form from digging blocks out underneath water under a solid block.  Apparently that is due to the fact that the Minecraft server does not consider a block that is "falling" (block data bit 0x8 set) as a valid source to consider for any of the two adjacent sources required to create a new source block.  And most (all?) ocean water blocks are configured as falling.  You can look closer at this logic here: https://github.com/B...owing.java#L282 (Although that is obfuscated code and can get ugly quickly)

I've been toying around with a plugin.  The plugin approach is clearly not as efficient as a direct edit to the server source code, but it's at least modular and a bit more customizable.

I would love any feedback on my source code: https://github.com/E...erfix/Main.java
You can test the plugin by downloading it from here: https://github.com/d...ix/WaterFix.jar