The point is using right click so if you weren't able to block with an item before, you'd end up doing whatever right click would have done. So if you were holding a sword, right click would have blocked, so shield blocks. If you were holding food, you'd be eating, and not block (as intended), and if you were holding potion, you'd throw it and not block, etc etc.
If he was to change it to 2 or R then he'd have to manually check whether or not you were supposed to block or not, and that is a lot of items (and think of mods).
I don't know if it relies on being bound to whichever key that uses the "Use Key" button (so that if a player changes the Use Key to something else it'd stay with that), but that would be the only improvement, then you could just change your use key to whatever you want. I still prefer right click.
Yeah it is nice, but there is a bug when you have your shield and sword on but then you right click too use your shield, your sword will stutter to (stuttering like the sword blocking).
See the thing is I have no idea ahead of time if the item is suppose to have a right click action unless it states it in its getItemUseAction() method (and that is only none, block, eat drink, block or bow). So for example I don't know if a tool has another function on right click (eg a hoe) so the easiest thing is to disallow the use. Besides holding a shield and a piece of dirt would look quite silly.
The only alternative is to manually check through item/block ids (which i would rather not do).
What weapon mod are you using? If it is Balkon's WeaponMod, then shielding works correctly with weapons that normally block (eg his battleaxe).
Ahh...I get your point there.The weapons from the other mods I was using was your other mod(battlecraft),invasion mod and humans+ mod.Which all of the weapons there do not have any blocking ability unabling me to wield the shield whenever I wield the weapons.
Well I better be practicing on fast switching *presses 1-2 num. buttons repeatedly*
I found a major bug, in version 1.0.0, blocking using the shield makes it, well make the blocking animation but it won't protect you, and yes i'm in the right positions to be protected, and the enemy is infront of me.
Looks very cool i wonder there was a different mod like this except it had different mod textures and can basiclly do the same thing as your mod ^^^^^ except it hadn't had a gui were you the mod creator who made that mod? or you just made your own shield mod
Your not in trouble or anything else im just curios
EDIT:Never mind found both of them both of the shield mods are great keep them up!
Is it ok with you if I do a mod review of this on my channel? Not many people are subbed to me, but at least some people will see it and hopefully come to check it out...
I was goofing off with this mod and i say i really like it! Also, i have made some more minecraft-ish textures for the shields. The leather shield is unchanged, however. Anyways, here are the textures I made for the shields: http://www.mediafire.com/?my2vwsdbraeab7x
Tell me what you think, also 5/5 diamonds for you for this mod
Just to let you guys all know I am about to go away for a couple of days. I may or may not have internet access (and If i do it will be via phone). Hopefully there aren't any major Issues in that time
Now to answer some questions/issues.
Shield Bashing
I quite like this idea, I could bind it to some key and it could provide an attack with no or minimal damage but a large knock back. Shouldn't be to hard (although 3rd person animation could be tricky).
Compatibility with Smart Moving
I will investigate compatibility with this mod. However I wouldn't hold my breath that it seems that this mod may screw around with the player renderer quite a bit. I will try of course
Compatibility with Aether
Again it looks like the Aether mod screws around with a lot of things also (they broke compatibility with my other mod also). I will of course look into it as well as possibly yell at (and by that I mean talk nicely) the Aether creators.
Shield not showing up in normal inventory
Yes I know this doesn't work. I didn't worry about showing the shield in this case because i didn't want to edit the GUIInventory class.
Blocking Bugs
Any bugs reports such as "I blocked but it still damaged me" don't really give me enough information to help. I really need more details.
People Asking If I "stole" this
No this is all my work. When I had my 1st beta out there was only 2 other mods adding shields (1 from adventure-craft & the other shields! by masonsbro). While my mod was in the WIP section 2 other were recently released (Asgard Shield Mod by Jade Knightblazer & a 2nd one called shields! by PandemicGaming). One of them take on the blocking problem in the same way i have.
In fact I am a little offended about the accusation.
Ok so, I tried to block an arrow from a dispenser, but it still damages me by the regular amount. I also noticed there was no slowing in movement while I was blocking with the shield. Also, blocking with a sword in your hand makes the sword spazz out between idle and blocking animations. I've right clicked with the sword without a shield equipped and it doesn't spazz out at all. I've tried the blocking with a shield from Too Many Items and with a shield that I crafted and it still damages me.
Do you plan on making Zelda shields like the Hylian shield, mirror shield and stuff?
cause that would be great 's to you!
scabbards would be great too.
Yeah it is nice, but there is a bug when you have your shield and sword on but then you right click too use your shield, your sword will stutter to (stuttering like the sword blocking).
Ahh...I get your point there.The weapons from the other mods I was using was your other mod(battlecraft),invasion mod and humans+ mod.Which all of the weapons there do not have any blocking ability unabling me to wield the shield whenever I wield the weapons.
Well I better be practicing on fast switching *presses 1-2 num. buttons repeatedly*
Your not in trouble or anything else im just curios
EDIT:Never mind found both of them both of the shield mods are great keep them up!
Tell me what you think, also
it seems to work ok at first but when you load a world it crashes :/ thanks :biggrin.gif:
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumNow to answer some questions/issues.
Shield Bashing
I quite like this idea, I could bind it to some key and it could provide an attack with no or minimal damage but a large knock back. Shouldn't be to hard (although 3rd person animation could be tricky).
Compatibility with Smart Moving
I will investigate compatibility with this mod. However I wouldn't hold my breath that it seems that this mod may screw around with the player renderer quite a bit. I will try of course
Compatibility with Aether
Again it looks like the Aether mod screws around with a lot of things also (they broke compatibility with my other mod also). I will of course look into it as well as possibly yell at (and by that I mean talk nicely) the Aether creators.
Shield not showing up in normal inventory
Yes I know this doesn't work. I didn't worry about showing the shield in this case because i didn't want to edit the GUIInventory class.
Blocking Bugs
Any bugs reports such as "I blocked but it still damaged me" don't really give me enough information to help. I really need more details.
People Asking If I "stole" this
No this is all my work. When I had my 1st beta out there was only 2 other mods adding shields (1 from adventure-craft & the other shields! by masonsbro). While my mod was in the WIP section 2 other were recently released (Asgard Shield Mod by Jade Knightblazer & a 2nd one called shields! by PandemicGaming). One of them take on the blocking problem in the same way i have.
In fact I am a little offended about the accusation.
Player API ovewrites SPC di.class file =/ meh
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThere is a patch for SPC to work with playerAPI on the SPC download page
cause that would be great
scabbards would be great too.